Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Something _WinUI_ did made tabs "slide" when they resize #15139

Closed
DHowett opened this issue Apr 7, 2023 · 3 comments · Fixed by #15313
Closed

Something _WinUI_ did made tabs "slide" when they resize #15139

DHowett opened this issue Apr 7, 2023 · 3 comments · Fixed by #15313
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.18

Comments

@DHowett
Copy link
Member

DHowett commented Apr 7, 2023

Windows Terminal version

1.18.96

Windows build number

No response

Other Software

No response

Steps to reproduce

I don't think this happened on 1.16.93 (!) which also had MUX 2.8

Have a tab. TabWidthMode = TitleLength (the one true setting)

Expected Behavior

No response

Actual Behavior

WindowsTerminal_20230407T102232_986
@DHowett DHowett added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 7, 2023
@zadjii-msft
Copy link
Member

Oh no I can't repro this on 1.18.931.0. I don't think that had MUX 2.8...

@zadjii-msft
Copy link
Member

The easiest way to repro this: just add this line

    "tabWidthMode": "titleLength",

and comment / uncomment

@zadjii-msft
Copy link
Member

This is the upstream microsoft/microsoft-ui-xaml#8384

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 11, 2023
@zadjii-msft zadjii-msft added this to the Terminal v1.18 milestone Apr 11, 2023
@zadjii-msft zadjii-msft changed the title Something we did made tabs "slide" when they resize Something _WinUI_ did made tabs "slide" when they resize Apr 11, 2023
zadjii-msft added a commit that referenced this issue May 8, 2023
@zadjii-msft
Reverts a MUX 2.8 bodge fix
65ea995 
reverts #15164

establishes that #15139 is fixed
@zadjii-msft zadjii-msft mentioned this issue May 8, 2023
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label May 8, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label May 10, 2023
DHowett pushed a commit that referenced this issue May 10, 2023
@zadjii-msft
Update MUX to 2.8.4 (#15313)
48eee4d 
Reverts #15164, because that's fixed upstream now.

Closes #15139. 

Reverts #15178, but also closes #15121, because that's fixed upstream.

see also:
* microsoft/microsoft-ui-xaml#8430
* microsoft/microsoft-ui-xaml#8420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.18
Development

Successfully merging a pull request may close this issue.

Update MUX to 2.8.4 microsoft/terminal
2 participants
@DHowett @zadjii-msft