Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mica in the SUI BG doesn't work on Win10 #14667

Closed
zadjii-msft opened this issue Jan 11, 2023 · 2 comments · Fixed by #14675
Closed

Mica in the SUI BG doesn't work on Win10 #14667

zadjii-msft opened this issue Jan 11, 2023 · 2 comments · Fixed by #14675
Assignees
@zadjii-msft
Labels
Area-Settings UI Anything specific to the SUI Area-Theming Anything related to the theming of elements of the window Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.17

Comments

@zadjii-msft
Copy link
Member

This build appears to have resolved it for me in initial testing, with a completely unrelated side effect of the dark mode for settings having the light mode color background rendering it completely unreadable (but it at least appears to resolve this actual issue from what I can see so far)

image

Originally posted by @spootle in #13388 (comment)
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 11, 2023
@zadjii-msft zadjii-msft self-assigned this Jan 11, 2023
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Area-Settings UI Anything specific to the SUI Area-Theming Anything related to the theming of elements of the window and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 11, 2023
@zadjii-msft
Copy link
Member Author

Pretty obviously, I set a transparent BG when we want mica, but there is no mica so it's just W H I T E

This was referenced Jan 12, 2023
Open
Merged
@ghost ghost added the In-PR This issue has a related PR label Jan 13, 2023
@zadjii-msft zadjii-msft added this to the Terminal v1.17 milestone Jan 13, 2023
@ghost ghost closed this as completed in #14675 Jan 19, 2023
ghost pushed a commit that referenced this issue Jan 19, 2023
@zadjii-msft
Only use Mica in the SUI if Mica is available (#14675)
f2b82cd 
This should make sure we only use Mica for the BG of the SUI when we're on a Windows build that supports it. Otherwise, we're just gonna get the emergency backstop / full transparency under it. 

Confirmed this fixes it on my win10 VM.

Closes #14667
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 19, 2023
@ghost
Copy link

ghost commented Jan 24, 2023

🎉This issue was addressed in #14675, which has now been successfully released as Windows Terminal Preview v1.17.1023.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-Settings UI Anything specific to the SUI Area-Theming Anything related to the theming of elements of the window Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.17
Development

Successfully merging a pull request may close this issue.

Only use Mica in the SUI if Mica is available microsoft/terminal
1 participant
@zadjii-msft