Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.17] theme schema needs updating #14560

Closed
carlos-zamora opened this issue Dec 15, 2022 · 3 comments · Fixed by #14666
Closed

[1.17] theme schema needs updating #14560

carlos-zamora opened this issue Dec 15, 2022 · 3 comments · Fixed by #14666
Assignees
@zadjii-msft
Labels
Area-Schema Things that have to do with the json schema. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.17

Comments

@carlos-zamora
Copy link
Member

GetImage (4)
@carlos-zamora carlos-zamora added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Area-Schema Things that have to do with the json schema. labels Dec 15, 2022
@carlos-zamora carlos-zamora added this to the Terminal v1.17 milestone Dec 15, 2022
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 15, 2022
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 15, 2022
@zadjii-msft zadjii-msft self-assigned this Dec 15, 2022
@zadjii-msft
Copy link
Member

dev/migrie/s/theme-schema

@zadjii-msft zadjii-msft mentioned this issue Jan 11, 2023
Merged
@ghost ghost added the In-PR This issue has a related PR label Jan 11, 2023
@zadjii-msft zadjii-msft mentioned this issue Jan 12, 2023
Merged
DHowett pushed a commit that referenced this issue Jan 13, 2023
@zadjii-msft
Add the Theme schema for 1.16 (#14672)
83d4009 
This is just #14666 ported to 1.16. Only diff is that useMica is removed. 

Related to #14560
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Needs-Tag-Fix Doesn't match tag requirements and removed In-PR This issue has a related PR labels Jan 14, 2023
carlos-zamora pushed a commit that referenced this issue Jan 14, 2023
@zadjii-msft
Update the Theme schema for 1.17 (#14666)
020746d 
What it says on the tin. 

I finally figured out the right way to validate schema updates in VsCode, which made this a lot faster. Tossed notes in the wiki for next time I do this. 

Closes #14560
@ghost
Copy link

ghost commented Jan 24, 2023

🎉This issue was addressed in #14666, which has now been successfully released as Windows Terminal v1.16.1023 (10231 and 10232).:tada:

Handy links:

@ghost
Copy link

ghost commented Jan 24, 2023

🎉This issue was addressed in #14666, which has now been successfully released as Windows Terminal Preview v1.17.1023.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-Schema Things that have to do with the json schema. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.17
Development

Successfully merging a pull request may close this issue.

Update the Theme schema for 1.17 microsoft/terminal
2 participants
@carlos-zamora @zadjii-msft