Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renderer encountered an unexpected error: -2005270483 #14316

Closed
elsaco opened this issue Nov 1, 2022 · 2 comments · Fixed by #15249
Closed

Renderer encountered an unexpected error: -2005270483 #14316

elsaco opened this issue Nov 1, 2022 · 2 comments · Fixed by #15249
Assignees
@zadjii-msft
Labels
Area-AtlasEngine Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@elsaco
Copy link

elsaco commented Nov 1, 2022

Windows Terminal version

main b4d37d8

Windows build number

10.0.22621.169 (aarch64)

Other Software

No response

Steps to reproduce

  • build latest source on Windows aarch64 (Windows DevKit 2023 used for testing)

Expected Behavior

  • terminal to launch

Actual Behavior

Error message: This terminal has encountered an issue with the graphics driver and it could not recover in time. It has been suspended.

Upon pressing Resume an error is thrown:

Screenshot 2022-10-31 190138
@elsaco elsaco added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 1, 2022
@zadjii-msft zadjii-msft changed the title Renderer encountered an unexpected error [ARM] Atlas Renderer encountered an unexpected error Nov 1, 2022
@zadjii-msft
Copy link
Member

I can repro this on my volterra too.

Error Code Symbolic Name Error Description Header
0x887a002d -2005270483 DXGI_ERROR_SDK_COMPONENT_MISSING The application requested an operation that depends on an SDK component that is missing or mismatched.

@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Priority-1 A description (P1) Area-AtlasEngine and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 1, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.17 milestone Nov 1, 2022
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Nov 1, 2022
@lhecker
Copy link
Member

lhecker commented Nov 1, 2022 •
edited
Loading

If you run a debug build you'll need to install the DirectX SDK. It should be part of the "Graphics debugger and GPU profiler for DirectX" component in the Visual Studio Installer. It happens because this isn't true and doesn't work:

terminal/src/renderer/atlas/AtlasEngine.cpp

Lines 551 to 552 in b4d37d8

// DXGI debug messages + enabling D3D11_CREATE_DEVICE_DEBUG if the Windows SDK was installed.
if (const wil::unique_hmodule module{ LoadLibraryExW(L"dxgi.dll", nullptr, LOAD_LIBRARY_SEARCH_SYSTEM32) })

If anyone wants to fix this, please do so! I just didn't have the time to set up a VM and test this just yet, especially since I personally always have the SDK installed for debugging purposes.

Edit: I changed the title so that this issue is easier to find.

@lhecker lhecker added Help Wanted We encourage anyone to jump in on these. Priority-3 A description (P3) and removed Priority-1 A description (P1) labels Nov 1, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 1, 2022
@lhecker lhecker changed the title [ARM] Atlas Renderer encountered an unexpected error Renderer encountered an unexpected error: -2005270483 Nov 1, 2022
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Nov 1, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Dec 1, 2022
@zadjii-msft zadjii-msft modified the milestones: Terminal v1.18, Backlog Apr 4, 2023
@zadjii-msft zadjii-msft self-assigned this Apr 27, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Apr 27, 2023
@zadjii-msft zadjii-msft mentioned this issue Apr 27, 2023
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Apr 27, 2023
DHowett pushed a commit that referenced this issue Apr 27, 2023
@zadjii-msft
Don't just die if the user doesn't have the dx debugging tools (#15249)
fc90045 
This PR gives the atlas engine an attempt to retry a couple operations
where it asks for debug flags when we're in debug mode. If you don't
have the Graphics debugger and GPU profiler for DirectX installed, then
these calls will fail, and we end up blowing up the renderer. Instead,
just try again.

Originally, I actually thought I had hit #14082, but after sorting this
out, it was just #14316.

closes #14316
@github-actions github-actions bot mentioned this issue Mar 7, 2024
Closed
@github-actions github-actions bot mentioned this issue Mar 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-AtlasEngine Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Don't just die if the user doesn't have the dx debugging tools microsoft/terminal
3 participants
@lhecker @elsaco @zadjii-msft