Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to disable dialog "Do you want to close all tabs?" like a checkbox in the dialog #14033

Closed
nk54 opened this issue Sep 19, 2022 · 3 comments · Fixed by #14419
Closed

Option to disable dialog "Do you want to close all tabs?" like a checkbox in the dialog #14033

nk54 opened this issue Sep 19, 2022 · 3 comments · Fixed by #14419
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Backlog

Comments

@nk54
Copy link

nk54 commented Sep 19, 2022

Hello, I know it's possible to edit the json to add
"confirmCloseAllTabs": false,

But it should be possible without having to search on the github issues to find there is a json setting available to do that.

It should be intuitive and easy to configure. Something like a checkbox in the dialog "never show this dialog again".

It's an issue from the UX point of view in my opinion.
Not hard to implement.

Anyway, thanks a lot. I lot Windows Terminal soooo much.
@nk54 nk54 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Sep 19, 2022
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 19, 2022
@nk54 nk54 changed the title Option to disable dialog "Do you want to close all tabs?" in options Option to disable dialog "Do you want to close all tabs?" like a checkbox in the dialog Sep 19, 2022
@lhecker lhecker added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Sep 20, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 20, 2022
@OlafvdSpek
Copy link

An option to close the current tab when you click the button to (accidentally) close the window might be handy too.

@lhecker lhecker added Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 12, 2022
@lhecker lhecker added this to the Backlog milestone Oct 12, 2022
@zadjii-msft zadjii-msft mentioned this issue Nov 21, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Nov 21, 2022
@zadjii-msft
Copy link
Member

This is getting added to the SUI in #14419, and the checkbox is tracked by #6641

@ghost ghost closed this as completed in #14419 Nov 21, 2022
ghost pushed a commit that referenced this issue Nov 21, 2022
@leejy12
Add the setting "confirmCloseAllTabs" to SUI (#14419)
437b5ac 
This commit adds the setting "confirmCloseAllTabs" to SUI.
The setting was added to the Interactions pane of Global Settings.

Closes #14413
Closes #14033
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Nov 21, 2022
DHowett pushed a commit that referenced this issue Dec 12, 2022
@leejy12 @DHowett
Add the setting "confirmCloseAllTabs" to SUI (#14419)
b73718a 
This commit adds the setting "confirmCloseAllTabs" to SUI.
The setting was added to the Interactions pane of Global Settings.

Closes #14413
Closes #14033

(cherry picked from commit 437b5ac)
Service-Card-Id: 87207138
Service-Version: 1.16
@ghost
Copy link

ghost commented Dec 14, 2022

🎉This issue was addressed in #14419, which has now been successfully released as Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Add the setting "confirmCloseAllTabs" to SUI leejy12/terminal
4 participants
@OlafvdSpek @lhecker @nk54 @zadjii-msft