Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.15] switchSelectionEndpoint doesn't work #13413

Closed
DHowett opened this issue Jul 1, 2022 · 1 comment · Fixed by #13435
Closed

[1.15] switchSelectionEndpoint doesn't work #13413

DHowett opened this issue Jul 1, 2022 · 1 comment · Fixed by #13435
Assignees
@carlos-zamora
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.15

Comments

@DHowett
Copy link
Member

DHowett commented Jul 1, 2022

Windows Terminal version

1.15

Windows build number

No response

Other Software

No response

Steps to reproduce

I entered mark mode (or just started with a mouse selection), and switchSelectionEndpoint doesn't do anything.

It might be important to note that I'm using it from the command palette.

Expected Behavior

No response

Actual Behavior

gif
@DHowett DHowett added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Jul 1, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 1, 2022
@carlos-zamora carlos-zamora added this to the Terminal v1.15 milestone Jul 1, 2022
@carlos-zamora carlos-zamora added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 1, 2022
@carlos-zamora
Copy link
Member

(putting this here for if somebody comes by before I do)
The weirdest thing! This doesn't repro on a Debug or Release build of main, but it 100% repros on the WT Preview build we're selfhosting! I'll take a closer look after the holidays!

@carlos-zamora carlos-zamora mentioned this issue Jul 5, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Jul 5, 2022
@carlos-zamora carlos-zamora mentioned this issue Jul 5, 2022
Open
11 tasks
@ghost ghost closed this as completed in #13435 Jul 5, 2022
ghost pushed a commit that referenced this issue Jul 5, 2022
@carlos-zamora
Update renderer on SwitchSelectionEndpoint (#13435)
66ecb0b 
## Summary of the Pull Request
In #13370, we should be notifying the renderer that the selection changed. Minor oversight and simple fix.

## References
#4993
#13370 
Closes #13413
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 5, 2022
DHowett pushed a commit that referenced this issue Jul 5, 2022
@carlos-zamora @DHowett
Update renderer on SwitchSelectionEndpoint (#13435)
9e05dcd 
## Summary of the Pull Request
In #13370, we should be notifying the renderer that the selection changed. Minor oversight and simple fix.

## References
#4993
#13370
Closes #13413

(cherry picked from commit 66ecb0b)
Service-Card-Id: 83892665
Service-Version: 1.15
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.15
Development

Successfully merging a pull request may close this issue.

Update renderer on SwitchSelectionEndpoint microsoft/terminal
2 participants
@DHowett @carlos-zamora