Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab context menu entries should have tooltips #13243

Closed
vadimkantorov opened this issue Jun 7, 2022 · 6 comments · Fixed by #14058
Closed

Tab context menu entries should have tooltips #13243

vadimkantorov opened this issue Jun 7, 2022 · 6 comments · Fixed by #14058
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone

Comments

@vadimkantorov
Copy link

This is sometimes needed as a last resort to find some info printed to the screen but unsaved anywhere else. Currently for doing this I had to do manual selection with mouse and then wait for ~1min for it to select all of scrollable viewport (hoping that selection doesn't break since it's quite jumpy), then copy to Notepad, then search.

So either allowing to copy the scrollable viewport into buffer and/or searching it directly can be useful.

@vadimkantorov vadimkantorov added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 7, 2022
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 7, 2022
@zadjii-msft
Copy link
Member

You mean something like:

/?

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 7, 2022
@vadimkantorov
Copy link
Author

vadimkantorov commented Jun 7, 2022

Yes, but making them more discoverable would be good. I've tried right-clicking on the tab (it seems to be doing PasteText in my case), there is no menu.

Only after you posted this, I found a context menu on the tab. Export Text proposed vadimkantorov@dell_de_vadim: /mnt/c/Users/vadim which is illegal file name in Windows.

Export Text should have a tooltip that explains what it does. does it export all scrollable viewport? or just current viewport? will it copy to clipboard or to text file?

Ctrl+Shift+P search bar does not find anything by "export" or "select".

Ctrl+Shift+P -> find does the right thing but it's hard to know it exists. Command Palette fast typing also makes for slow rendering, it reacts slower than I type and it's strange. It should not try to re-render the drop-down too fast, better to skip some intermediate searches than re-render and flicker (also it seems a bit slow at rendering, XAML bites again I suppose)

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jun 7, 2022
@zadjii-msft
Copy link
Member

right-clicking on the tab (it seems to be doing PasteText in my case), there is no menu

That's tracked in #3337

Export Text should have a tooltip that explains what it does

Fair - none of those context menu entries have tooltips. Repurposing this issue for that.

Ctrl+Shift+P search bar does not find anything by "export" or "select".

What version are you on? selectAll was added in 1.14, but exportBuffer was added to the default actions in #12097, which should appear as "Export Buffer" in english.

@zadjii-msft zadjii-msft changed the title Search / copy all of the scrollable viewport Tab context menu entries should have tooltips Jun 8, 2022
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. good first issue This is a fix that might be easier for someone to do as a first contribution and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Jun 8, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 8, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Jun 8, 2022
@zadjii-msft zadjii-msft removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Attention The core contributors need to come back around and look at this ASAP. labels Jun 8, 2022
@zadjii-msft zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label Jul 25, 2022
@vertigo220

This comment was marked as off-topic.

@zadjii-msft

This comment was marked as off-topic.

@ghost ghost added the In-PR This issue has a related PR label Sep 22, 2022
@ghost ghost closed this as completed in #14058 Sep 30, 2022
ghost pushed a commit that referenced this issue Sep 30, 2022
Add tooltips to the tab context menu and the tab dropdown menu.

Closes #13243
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Sep 30, 2022
@ghost
Copy link

ghost commented Jan 24, 2023

🎉This issue was addressed in #14058, which has now been successfully released as Windows Terminal Preview v1.17.1023.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants