[Settings - Startup]: Name is not defined for the button present under 'Startup' tab. #13019
Labels
A11yCO
Accessibility tracking
A11ySev2
Accessibility tracking
A11yWCAG
Accessibility tracking
Area-Accessibility
Issues related to accessibility
HCL-E+D
Accessibility tracking
HCL-WindowsTerminal
Accessibility tracking
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Product-Terminal
The new Windows Terminal.
Resolution-Fix-Committed
Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Comments
ghost
added
Issue-Bug
zadjii-msft
removed
the
Needs-Triage
|
Hey look, @carlos-zamora was right, this one would get picked up. Previous thread: #12317 |
6 tasks
ghost
added
Resolution-Fix-Committed
ghost
pushed a commit
that referenced
this issue
May 4, 2022
## Summary of the Pull Request Make sure we set `Name` and `FullDescription` on expander-style settings in the SUI ## PR Checklist * [x] Closes #13019 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here ## Validation Steps Performed Accessibility insights now shows the name/full description for the expander-style settings
carlos-zamora
pushed a commit
that referenced
this issue
May 12, 2022
## Summary of the Pull Request Make sure we set `Name` and `FullDescription` on expander-style settings in the SUI ## PR Checklist * [x] Closes #13019 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here ## Validation Steps Performed Accessibility insights now shows the name/full description for the expander-style settings (cherry picked from commit 71cbdc8) Service-Card-Id: 81446420 Service-Version: 1.13
|
🎉This issue was addressed in #13032, which has now been successfully released as Handy links: |
|
🎉This issue was addressed in #13032, which has now been successfully released as Handy links: |
|
Closing as fixed now Version: 1.13.11432.0 |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Windows Terminal version
1.13.10984.0
Windows build number
22598.200
Other Software
Test Environment:
OS: Windows 11 Version 21H2 (OS Build 22598.200)
Screen Reader: Narrator
Steps to reproduce
Repro Steps:
Open Windows Terminal.
Open Settings page using "Ctrl + ',' ".
Verify that Name is not defined for the button present under 'Startup' tab.
User Experience: -> Priority 1
User who relies on screen reader will be affected and not be able to know what the control is and what is its functionality if name is not defined for the control.
Guideline Reference:
https://www.w3.org/WAI/WCAG21/Understanding/name-role-value.html
Attachments:
Name is not defined for the button present under 'Startup' tab..zip
Expected Behavior
Name should be defined for the button present under 'Startup' tab.
Screen reader should announce "When terminal starts button collapse/expand button".
Actual Behavior
Name is not defined for the button present under 'Startup' tab.
Screen reader announces, "group collapse".
The text was updated successfully, but these errors were encountered: