Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal doesn't remember maximized, focus, fullscreen states #11426

Closed
zadjii-msft opened this issue Oct 5, 2021 · 1 comment · Fixed by #12073
Closed

Terminal doesn't remember maximized, focus, fullscreen states #11426

zadjii-msft opened this issue Oct 5, 2021 · 1 comment · Fixed by #12073
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
22H2

Comments

@zadjii-msft
Copy link
Member

found in 1.12.2781.0 Bug Bash on 10/5/2021

Terminal doesn't remember maximized, focus, fullscreen states. This is currently by-design but also annoying.

Repro:

  1. Open the window
  2. enable window restoring
  3. maximize
  4. close the window
  5. open the terminal

It'll be the size of a maximized window, but it won't be maximized. Same with focus mode, etc.
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Priority-2 A description (P2) Area-Windowing Window frame, quake mode, tearout labels Oct 5, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Oct 5, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 5, 2021
@zadjii-msft zadjii-msft mentioned this issue Oct 5, 2021
Open
16 tasks
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 15, 2021
@zadjii-msft zadjii-msft mentioned this issue Oct 28, 2021
Open
@Rosefield Rosefield mentioned this issue Dec 31, 2021
Merged
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@ghost ghost added the In-PR This issue has a related PR label Jan 5, 2022
@ghost ghost closed this as completed in #12073 Jan 10, 2022
ghost pushed a commit that referenced this issue Jan 10, 2022
@Rosefield
Persist Runtime TabTitle and Maximize/Focus/Fullscreen states (#12073)
acbfb30 
This commit adds additional information to the persisted window layouts.
- Runtime tab titles
- Focus, Maximized, and Fullscreen modes.

Also,
- Adds actions for Set{Focus,FullScreen} that take a boolean
  to work in addition to the current Toggle{Focus, Fullscreen} actions.
- Adds SetMaximized that takes a boolean.
  This adds the capability to maximize (resp restore) a window using
  standard terminal actions.
  This also involves hooking up a good amount of state tracking between
  the terminal page and the window to see when maximize state has changed
  so that it can be persisted.
- These actions are not added to the default settings, but they could be.
  The intention is that they could assist with automation (and was originally)
  how I planned on persisting the state instead of augmenting the LaunchMode.
- The fullscreen/maximized saving isn't perfect because we don't have a
  way to save the non-maximized/fullscreen size, so exiting the modes
  won't restore whatever the previous size was.

References #9800 
Closes #11878 
Closes #11426
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 10, 2022
@ghost
Copy link

ghost commented Feb 3, 2022

🎉This issue was addressed in #12073, which has now been successfully released as Windows Terminal Preview v1.13.10336.0.:tada:

Handy links:

@github-actions github-actions bot mentioned this issue Dec 15, 2023
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
22H2
Development

Successfully merging a pull request may close this issue.

Persist Runtime TabTitle and Maximize/Focus/Fullscreen states Rosefield/terminal
2 participants
@DHowett @zadjii-msft