Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Settings]: Radio buttons are not associated with its main label throughout the settings page. #11248

Closed
Tracked by #9990
ghost opened this issue Sep 16, 2021 · 7 comments
Closed
Tracked by #9990

[Settings]: Radio buttons are not associated with its main label throughout the settings page. #11248

ghost opened this issue Sep 16, 2021 · 7 comments
Labels
A11ySev3 Accessibility tracking A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.13

Comments

@ghost
Copy link

ghost commented Sep 16, 2021 •
edited by ghost
Loading

Windows Terminal version (or Windows build number)

1.10.2383.0

Other Software

Test Environment:
OS: Windows 11 Version 21H2 (OS Build 22000.168)
Screen Reader: Narrator
Tool: Accessibility Insight for Windows

Steps to reproduce

Repro Steps:

  1. Open Windows Terminal.
  2. Open Settings page using "Ctrl + ',' ".
  3. Open Narrator using 'Win + Ctrl+ Enter' key.
  4. Navigate through all radio groups through Settings page and observe the issue.

User Experience:
Screen Reader user are impacted here as they will not be able to know the exact purpose of radio buttons as main label is not announced to them.

Guideline Reference:
https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships

Attachments:
Radio buttons are not associated with its main label..zip

Expected Behavior

Radio buttons should be associated with its main label throughout the Settings page. i.e. For 'Default' radio button with group label 'Launch mode' Screen Reader should announce 'Launch mode group Default radio button selected 1 of 5'

Actual Behavior

Radio buttons is not associated with its main label throughout the Settings page. i.e. For 'Default' radio button with group label 'Launch mode' Screen Reader is announcing 'Default radio button selected 1 of 5'

Observation: Same issue repro with NVDA Screen Reader.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements A11ySev3 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. labels Sep 16, 2021
@zadjii-msft zadjii-msft added the Priority-3 A description (P3) label Sep 16, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Sep 16, 2021
@ghost ghost changed the title [Settings]: Radio buttons are not associated with its main label. [Settings]: Radio buttons are not associated with its main label throughout the settings page. Sep 16, 2021
@DHowett DHowett added Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 16, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 16, 2021
@zadjii-msft
Copy link
Member

This looks like #9567 which is actually tracked by the upstream microsoft/microsoft-ui-xaml#3183. @v-rpundir can you confirm?

@ghost
Copy link
Author

ghost commented Oct 6, 2021

@zadjii-msft Yeah it is similar to #9567 but the Upstream bug is closed as fixed now.

@zadjii-msft
Copy link
Member

Looks like the upstream bug was fixed in microsoft/microsoft-ui-xaml#5094 which was in WinUI 2.6.1, so hopefully the 1.12 builds of the Terminal (which moved to WinUI 2.7) should have the fix.

Looks like it's still not grouping them though:
image

Maybe there's something else we need to do to manually combine these now.

This was referenced Oct 6, 2021
Closed
Merged
@zadjii-msft zadjii-msft linked a pull request Oct 6, 2021 that will close this issue
Wire up RadioButtons as groups in UIA #11442
Merged
3 tasks
@zadjii-msft zadjii-msft removed a link to a pull request Oct 6, 2021
Wire up RadioButtons as groups in UIA #11442
Merged
3 tasks
@zadjii-msft zadjii-msft added the In-PR This issue has a related PR label Oct 6, 2021
@DHowett
Copy link
Member

DHowett commented Oct 6, 2021

Looks like it's still not grouping them though:

I suspect we need to do something special with SettingContainer, assuming that this is using it

ghost pushed a commit that referenced this issue Oct 7, 2021
@zadjii-msft
Wire up RadioButtons as groups in UIA (#11442)
bc4f410 
I thought that microsoft/microsoft-ui-xaml#3183 might just fix this for us, but it didn't. We've got our RadioButton's all up in SettingsContainers, so they all think they're `AutomationProperties.AccessibilityView="Raw"` for some reason. If you simply add the `Content` to these, then they all end up correct in Accessibility Insights

## PR Checklist
* [x] Will take care of #11248 but I can't be the one to close it.
* [x] I work here
* [x] Tests added/passed
* [n/a] Requires documentation to be updated
PankajBhojwani pushed a commit that referenced this issue Oct 15, 2021
@zadjii-msft @PankajBhojwani
Wire up RadioButtons as groups in UIA (#11442)
928c875 
I thought that microsoft/microsoft-ui-xaml#3183 might just fix this for us, but it didn't. We've got our RadioButton's all up in SettingsContainers, so they all think they're `AutomationProperties.AccessibilityView="Raw"` for some reason. If you simply add the `Content` to these, then they all end up correct in Accessibility Insights

* [x] Will take care of #11248 but I can't be the one to close it.
* [x] I work here
* [x] Tests added/passed
* [n/a] Requires documentation to be updated

(cherry picked from commit bc4f410)
@zadjii-msft zadjii-msft mentioned this issue Jan 3, 2022
Open
12 tasks
@zadjii-msft
Copy link
Member

@v-rpundir I believe this was fixed in Preview v1.12.2922.0/Stable v1.11.2921.0, could you confirm?

@ghost
Copy link
Author

ghost commented Jan 27, 2022

Closing as the bug as fixed in Windows Terminal Preview Version: 1.12.3472.0

@ghost ghost closed this as completed Jan 27, 2022
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jan 27, 2022
@Priyanka-Chauhan123 Priyanka-Chauhan123 added the A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. label Jan 8, 2024
@Priyanka-Chauhan123
Copy link
Collaborator

Closing the bug as UI has been changed.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A11ySev3 Accessibility tracking A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.13
Development

No branches or pull requests
3 participants
@DHowett @zadjii-msft @Priyanka-Chauhan123