-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows 11 22000.65] Default Terminal does not work with 1.9! #10594
Comments
Thanks for the report! There's a version mismatch between Terminal 1.9 and 22000.65. We had to introduce a new "default terminal" code path because the one we had introduced for 22000.51 was broken. Until we release Terminal 1.10 to Preview, this will not work. Sorry! |
@DHowett so basically it was done to fix the problem, I reported, that if you set terminal as conhost and you add auto start scripts in the Startup folders, sometime when the system start you got a windows cannot start app? |
This is also the case on Microsoft Windows [Version 10.0.21390.2025]. Set Terminal Preview as default terminal application but Console Host is used when running Command Prompt or Powershell. |
[22000.65] I checked for updates on the Store and it updated Terminal Preview to 1.10.1933.0 , the problem is finally solved! Now cmd, ps, wsl etc. open with Terminal Preview if set as default! Thanks to all the devs! 2021_07_15_160256.mp4 |
@obrobrio2000, This still does not work on Microsoft Windows [Version 10.0.21390.2025] with Terminal Preview 1.10.1933.0. |
Thanks for letting me know, I reopened the issue. |
That release predates the revised handoff interface, and I believe that it is an insider build that is not currently receiving updates to any of our components. Our recent work is available in Insider builds 22000 and beyond. |
@ayamadori same as you (22000.71 and 1.10.1993.0) but it seems working fine on my end. 2021_07_18_055325.2.mp4 |
@obrobrio2000, @ayamadori, Strange. It still does not work on my machine. Are there any steps required other than changing the setting on the Terminal? |
windows 11 PRO build 22000.100 |
Rebooting solved it..🤦♂️ |
This seems to be fixed... (Windows 10.0.22000.120, Terminal Preview 1.10.1933.0) |
Not working with Windows 11 22000.160 with Windows Terminal Preview 1.101.933.0 Only unusual thing about my install is I don't have Windows activated (trying it out in a VM). I don't see any messages in Windows Settings indicating that would stop this feature from working though. I also had installed PowerShell 7, as well as Windows Terminal Stable and Preview, all through winget (shouldn't matter). Things I tried:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@n-gao, @swift-lee That's correct. From the blog post for 1.11:
|
@The-MAZZTer If you're still seeing this, can you share what's in |
FWIW, I tried to install and use VirtualBox 6.1.26 on my Windows 11 host machine and it couldn't start any VMs. I wonder if that's a known issue for VirtualBox and I need a Windows 10 host machine? |
Any updates on this? Given the release of Windows 11 is under 24 hours away at time of writing, I'd love to know whether this was nearing stability... (On the fence about using the preview version of the terminal, since the only thing I'm after is the default console setting) |
@CDAGaming This isn't the thread for that discussion, though I'm not sure there is another one. This one's tracking a very specific bug in the defterm implementation that we're still trying to track down, but there's only the one user with the repro. I'm gonna file another issue to track that discussion in the immediate future. |
If you want to discuss that topic more, let's move over to #11415. We still haven't found anything that looks like a root cause for this one, nor do we have any live repros unfortunately. |
@The-MAZZTer These questions might seem silly, but I'm just trying to correlate with an internal report of a similar bug. Are you by any chance running on an ARM CPU? Even more wildly: Is the copy of Windows you're running in VirtualBox activated? We've got a crazy theory that the second bit might somehow be causing this to fail (but we've still got NO idea why that might be) |
@zadjii-msft While we're waiting on The-MAZZTer's reply, I will chime in that I can also reproduce this with:
|
@NotTheDr01ds Are you by any chance running on an ARM CPU? |
@zadjii-msft I knew I would miss some critical information in there :-). No. The host CPU is an i5-9500T. The kvm setup is per this guide, so the guest is "Skylake, IBRS, No TSX". |
Considering the number of reports of "defterm isn't working (mysteriously)", I figured more logging current hurt. I also added a wprp profile for the defterm logging as well, which should capture conhost side things as well. From an elevated conhost: ``` wpr -start path\to\Terminal.wprp!Defterm.Verbose wpr -stop %USERPROFILE%\defterm-trace.etl ``` * [x] I work here * [x] relevant to: #10594, #11529, #11524.
Considering the number of reports of "defterm isn't working (mysteriously)", I figured more logging current hurt. I also added a wprp profile for the defterm logging as well, which should capture conhost side things as well. From an elevated conhost: ``` wpr -start path\to\Terminal.wprp!Defterm.Verbose wpr -stop %USERPROFILE%\defterm-trace.etl ``` * [x] I work here * [x] relevant to: #10594, #11529, #11524. (cherry picked from commit 284257a)
Considering the number of reports of "defterm isn't working (mysteriously)", I figured more logging current hurt. I also added a wprp profile for the defterm logging as well, which should capture conhost side things as well. From an elevated conhost: ``` wpr -start path\to\Terminal.wprp!Defterm.Verbose wpr -stop %USERPROFILE%\defterm-trace.etl ``` * [x] I work here * [x] relevant to: #10594, #11529, #11524.
@NotTheDr01ds @The-MAZZTer We think we have a fix for this over in #11610. Could you do the steps in this comment: #11529 (comment) and send me the trace? I should be able to tell from the trace if this you were hitting the same cause. Even if it's not, we should probably move the discussion to a new thread, just so we can follow up and track the bug separately. |
@zadjii-msft Alright, I haven't updated my VM to Windows 11 RTM so it is still on 22458.1000, and I generated the trace using it. Let me know if you want a trace running on Windows 11 RTM or whatever. Trace sent to your e-mail as directed. |
Yep, that's the same thing. Manually installing the visual c++ redistributable will probably fix this for you. We'll probably roll out a hotfix with #11610 in it soon enough. Thanks everyone for the persistence on this one! |
I'm seeing this issue when I run cmd.exe as ADMINISTRATOR. It works fine when I run it as "regular user". Steps to repro:
Actual results: Expected result: Windows version: 10.0.22000.282 |
@szilvaa-adsk Please read the FAQ.
|
This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. |
@zadjii-msft Missed your other questions, I'm running on a x64 host (is there even an ARM VirtualBox?) and I didn't activate Windows 11 since I don't have a license, apart from a couple Windows 10 ones (just wanted to take a sneak peek before I update my Windows 10 PC). |
@The-MAZZTer Oh sorry, we moved on past those theories. We believe this was due to an accidental dependency on the CRT. Manually installing the C Runtime should fix this (until we roll out a hotfix build of the Terminal that doesn't have this dependency anymore) |
This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. |
MAINTAINER NOTE
There's a version mismatch between Terminal 1.9 and 22000.65. We had to introduce a new "default terminal" code path because the one we had introduced for 22000.51 was broken.
Until we release Terminal 1.10 to Preview, this will not work.
Original Report
Windows Terminal version (or Windows build number)
10.0.22000.65, 1.9.1523.0
Other Software
No response
Steps to reproduce
Expected Behavior
Terminal Preview should be used as the default terminal, respecting user's choice.
Actual Behavior
After 22000.65 update, Console Host is always used instead of Terminal Preview (ignoring user's choice). Even if I set Terminal Preview as the default terminal instead of conhost, it always opens everything (cmd, powershell, wsl2 etc.) in conhost.
Feedback Hub link: https://aka.ms/AAd5hc6
The text was updated successfully, but these errors were encountered: