Fix signed/unsigned mismatches.

microsoft · Mar 16, 2023 · 2effde0 · 2effde0
1 parent 89bbb0f
commit 2effde0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/terminal/adapter/adaptDispatch.cpp b/src/terminal/adapter/adaptDispatch.cpp
@@ -3987,7 +3987,7 @@ ITermDispatch::StringHandler AdaptDispatch::_RestoreTabStops()
         {
             // Note that column 1 is always a tab stop, so there is no
             // need to record an entry at that offset.
-            if (column > 1 && column <= width)
+            if (column > 1u && column <= static_cast<size_t>(width))
             {
                 _tabStopColumns.at(column - 1) = true;
             }

diff --git a/src/terminal/adapter/ut_adapter/adapterTest.cpp b/src/terminal/adapter/ut_adapter/adapterTest.cpp
@@ -2094,12 +2094,12 @@ class AdapterTest
 
         Log::Comment(L"Restore charset configuration");
         stateMachine.ProcessString(L"\033P1$t1;1;1;@;@;@;3;1;H;ABCF\033\\");
-        VERIFY_ARE_EQUAL(3, termOutput.GetLeftSetNumber());
-        VERIFY_ARE_EQUAL(1, termOutput.GetRightSetNumber());
-        VERIFY_ARE_EQUAL(94, termOutput.GetCharsetSize(0));
-        VERIFY_ARE_EQUAL(94, termOutput.GetCharsetSize(1));
-        VERIFY_ARE_EQUAL(94, termOutput.GetCharsetSize(2));
-        VERIFY_ARE_EQUAL(96, termOutput.GetCharsetSize(3));
+        VERIFY_ARE_EQUAL(3u, termOutput.GetLeftSetNumber());
+        VERIFY_ARE_EQUAL(1u, termOutput.GetRightSetNumber());
+        VERIFY_ARE_EQUAL(94u, termOutput.GetCharsetSize(0));
+        VERIFY_ARE_EQUAL(94u, termOutput.GetCharsetSize(1));
+        VERIFY_ARE_EQUAL(94u, termOutput.GetCharsetSize(2));
+        VERIFY_ARE_EQUAL(96u, termOutput.GetCharsetSize(3));
         VERIFY_ARE_EQUAL(VTID("A"), termOutput.GetCharsetId(0));
         VERIFY_ARE_EQUAL(VTID("B"), termOutput.GetCharsetId(1));
         VERIFY_ARE_EQUAL(VTID("C"), termOutput.GetCharsetId(2));