Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify npm engine version is specified #81

Open
SvenAelterman opened this issue May 25, 2022 · 2 comments · May be fixed by #123
Open

Verify npm engine version is specified #81

SvenAelterman opened this issue May 25, 2022 · 2 comments · May be fixed by #123
Assignees
@softcraftsman @SvenAelterman
Labels
deployment Automating or enhancing the deployment experience
Milestone
Backlog

Comments

@SvenAelterman
Copy link
Contributor

To resolve build warnings on package.json file format version. See Azure/static-web-apps#694 (comment).
@SvenAelterman SvenAelterman added the deployment Automating or enhancing the deployment experience label May 25, 2022
@SvenAelterman SvenAelterman added this to the Backlog milestone May 25, 2022
@SvenAelterman SvenAelterman self-assigned this May 25, 2022
@SvenAelterman SvenAelterman mentioned this issue Jun 29, 2022
Merged
@softcraftsman softcraftsman self-assigned this Jun 30, 2022
softcraftsman added a commit that referenced this issue Jun 30, 2022
@softcraftsman
Verify npm engine version is specified
5b2e4ce 
Fixes #81
@SvenAelterman
Copy link
Contributor Author

Merged PR did not address this issue.

@SvenAelterman SvenAelterman reopened this Jun 30, 2022
softcraftsman added a commit that referenced this issue Aug 1, 2022
@softcraftsman
#81 - Verify npm engine is specified
4438ed5
@SvenAelterman
Copy link
Contributor Author

Merged PR did not address this issue. engines specified in package-lock.json, but Oryx looks at package.json.

@SvenAelterman SvenAelterman linked a pull request Aug 16, 2022 that will close this issue
Defined minimum npm, node version (package.json) #112
Closed
@SvenAelterman SvenAelterman removed a link to a pull request Aug 31, 2022
Defined minimum npm, node version (package.json) #112
Closed
@SvenAelterman SvenAelterman linked a pull request Aug 31, 2022 that will close this issue
Specify npm and node versions in package.json #123
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@softcraftsman softcraftsman

@SvenAelterman SvenAelterman

Labels
deployment Automating or enhancing the deployment experience
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Specify npm and node versions in package.json microsoft/storage-as-a-service
2 participants
@softcraftsman @SvenAelterman