Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'LedgerViewType' as supported property for SQL 2022 and Azure DBs #1801

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Add 'LedgerViewType' as supported property for SQL 2022 and Azure DBs #1801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/Microsoft.SqlTools.ServiceLayer/ObjectExplorer/SmoModel/SmoTreeNodes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,6 +921,20 @@ public override IEnumerable<INodeFilter> Filters
}
}

public override IEnumerable<NodeSmoProperty> SmoProperties
{
get
{
var properties = new List<NodeSmoProperty>();
properties.Add(new NodeSmoProperty
{
Name = "LedgerViewType",
cheenamalhotra marked this conversation as resolved.
Show resolved Hide resolved
ValidFor = ValidForFlag.Sql2022|ValidForFlag.AzureV12
cheenamalhotra marked this conversation as resolved.
Show resolved Hide resolved
});
return properties;
}
}

protected override void OnExpandPopulateFolders(IList<TreeNode> currentChildren, TreeNode parent)
{
currentChildren.Add(new FolderNode {
Expand Down
3 changes: 3 additions & 0 deletions src/Microsoft.SqlTools.ServiceLayer/ObjectExplorer/SmoModel/SmoTreeNodesDefinition.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@
<Filter Property="IsSystemObject" Value="0" Type="bool" />
<Filter Property="IsDroppedLedgerView" Value="0" Type="bool" ValidFor="Sql2022|AzureV12"/>
</Filters>
<Properties>
<Property Name="LedgerViewType" ValidFor="Sql2022|AzureV12"/>
</Properties>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can't OE pick up the property list from here instead of requiring the C# code override?

<Child Name="SystemViews" IsSystemObject="1"/>
<Child Name="DroppedLedgerViews"/>
</Node>
Expand Down