Fix an issue with webpack error printing. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
octogonz,
apostolisms and
D4N14L
as code owners
D4N14L
approved these changes
Sep 10, 2024
iclanton
force-pushed
the
fix-webpack-error-formatting
branch
from
8005d5e to
ffcc86c
Compare
iclanton
force-pushed
the
fix-webpack-error-formatting
branch
from
ffcc86c to
31d115a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes SharePoint/sp-dev-docs#9834.
Details
Errors were assumed to still be strings in Webpack 5, which is no longer the case. This change normalizes them.
How it was tested
Created a bundling issue in SPFx 1.19 and confirmed that it's printed as expected.
Before:
After:
