[proxy](7/n) proxy array and algorithm headers #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchrodingerZhu
force-pushed
the
proxy-array
branch
5 times, most recently
from
97b2d9a to
2b26c85
Compare
SchrodingerZhu
changed the title
SchrodingerZhu
force-pushed
the
proxy-array
branch
from
2b26c85 to
9aa79fa
Compare
SchrodingerZhu
force-pushed
the
proxy-array
branch
from
9aa79fa to
20a4e40
Compare
SchrodingerZhu
force-pushed
the
proxy-array
branch
from
31ede07 to
d6b807f
Compare
mjp41
reviewed
Jan 2, 2025
Comment on lines
+20
to
+29
| constexpr SNMALLOC_FAST_PATH const T& max(const T& a, const T& b) | ||
| { | ||
| return a < b ? b : a; | ||
| } | ||
|
|
||
| template<typename T> | ||
| constexpr SNMALLOC_FAST_PATH const T& min(const T& a, const T& b) | ||
| { | ||
| return a < b ? a : b; | ||
| } |
There was a problem hiding this comment.
Theses are also defined in bits.h could we simplify now?
| @@ -156,7 +157,7 @@ namespace snmalloc | |||
| */ | |||
| SNMALLOC_UNUSED_FUNCTION | |||
| static constexpr size_t LargestRegisterSize = | |||
| std::max(sizeof(uint64_t), sizeof(void*)); | |||
| proxy::max(sizeof(uint64_t), sizeof(void*)); | |||
There was a problem hiding this comment.
Could this use, then we wouldn't need to vendor std::max/std::min?
Suggested change
| proxy::max(sizeof(uint64_t), sizeof(void*)); | |
| bits::max(sizeof(uint64_t), sizeof(void*)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch clears all STL dependency in the core header library.
Stacked on #721