Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to support SSDT SDK project type guid #623

Conversation

Saurabhfaujdar
Copy link
Contributor

@Saurabhfaujdar Saurabhfaujdar commented Oct 21, 2024

Now we ship two visual studio extensions of SSDT. One of which supports SDK styled projects and another one for legacy styled projects. But file extension is still same for both kind of projects as ultimate goal is to migrate the customers to new extension. Adding logic to correctly identify guid for SSDT SDK project type.

@Saurabhfaujdar
Copy link
Contributor Author

Saurabhfaujdar commented Nov 4, 2024 via email

@Saurabhfaujdar
Copy link
Contributor Author

Saurabhfaujdar commented Nov 4, 2024 via email

@Saurabhfaujdar
Copy link
Contributor Author

Saurabhfaujdar commented Nov 4, 2024 via email

@Saurabhfaujdar Saurabhfaujdar marked this pull request as ready for review November 4, 2024 20:54
@jeffkl
Copy link
Collaborator

jeffkl commented Nov 5, 2024

@mruxmohan4 please take a look

@mruxmohan4
Copy link
Contributor

It looks like MessagePack package needs to be upgraded. Will fix that later tonight and restart the builds to hopefully unblock this. If there are additional blockers, will investigate and reach out to someone who can provide better assistance.

Thank you for your contribution!

@mruxmohan4
Copy link
Contributor

@Saurabhfaujdar, could you rebase your branch to get the latest changes from main?

@Saurabhfaujdar Saurabhfaujdar force-pushed the dev/saurabh/AddSQLSDKProjectTypeGuid branch 2 times, most recently from d401e4b to 96e067a Compare November 6, 2024 08:48
@AndyGerlicher AndyGerlicher merged commit eb5f73f into microsoft:main Nov 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants