-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding generic version entities for SFS API Responses #91
Merged
arthuraraujo-msft
merged 5 commits into
main
from
user/arthuraraujo/adding-response-interfaces
Mar 7, 2024
Merged
Adding generic version entities for SFS API Responses #91
arthuraraujo-msft
merged 5 commits into
main
from
user/arthuraraujo/adding-response-interfaces
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihan-msft
approved these changes
Mar 1, 2024
JeffMill
requested changes
Mar 5, 2024
This was referenced Mar 5, 2024
JeffMill
approved these changes
Mar 7, 2024
arthuraraujo-msft
force-pushed
the
user/arthuraraujo/adding-response-interfaces
branch
from
March 7, 2024 11:30
3d0e3a7
to
5b5899b
Compare
arthuraraujo-msft
deleted the
user/arthuraraujo/adding-response-interfaces
branch
March 7, 2024 12:07
This was referenced Mar 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #50
For the same APIs, SFS will start sending different fields in the response. which may or not be present. While an offline discussion goes on about how the client should specify which entity it wants, we must be able to parse the different responses to be ready for the App version changes.
For example:
Generic Version Entity:
App Version Entity:
In order to avoid creating one implementation for each entity, I'm switching the 1:1 APIs to return more generic entities that can be mapped to a single entity. The API implementations won't be aware of the types, that will only be taken care of during parsing from the server, and during transformation in the final step.
For this PR I'm adding a Generic entity, which is the current response schema of SFS. The App version entity should be coming next.