Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in poem generated by chatbot #995

Merged
merged 1 commit into from
May 15, 2023

Conversation

lemillermicrosoft
Copy link
Member

@lemillermicrosoft lemillermicrosoft commented May 15, 2023

This commit fixes a typo in the e2e_text_completion.py test file, where the word "signularity" was misspelled as "singularity". This could cause confusion or errors in the test output. The typo was corrected to "singularity" to match the intended meaning of the poem. No other changes were made to the test file or the functionality of the chatbot.

Contribution Checklist

@github-actions github-actions bot added the python Pull requests for the Python Semantic Kernel label May 15, 2023
@lemillermicrosoft lemillermicrosoft added PR: ready for review All feedback addressed, ready for reviews PR: ready to merge PR has been approved by all reviewers, and is ready to merge. and removed python Pull requests for the Python Semantic Kernel labels May 15, 2023
@lemillermicrosoft lemillermicrosoft marked this pull request as ready for review May 15, 2023 14:37
This commit fixes a typo in the e2e_text_completion.py test file, where
the word "signularity" was misspelled as "singularity". This could cause
confusion or errors in the test output. The typo was corrected to
"singularity" to match the intended meaning of the poem. No other
changes were made to the test file or the functionality of the chatbot.
@github-actions github-actions bot added the python Pull requests for the Python Semantic Kernel label May 15, 2023
@lemillermicrosoft lemillermicrosoft enabled auto-merge (squash) May 15, 2023 14:51
@lemillermicrosoft lemillermicrosoft merged commit 6d148f5 into microsoft:main May 15, 2023
shawncal pushed a commit to johnoliver/semantic-kernel that referenced this pull request May 19, 2023
This commit fixes a typo in the e2e_text_completion.py test file, where
the word "signularity" was misspelled as "singularity". This could cause
confusion or errors in the test output. The typo was corrected to
"singularity" to match the intended meaning of the poem. No other
changes were made to the test file or the functionality of the chatbot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready for review All feedback addressed, ready for reviews PR: ready to merge PR has been approved by all reviewers, and is ready to merge. python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants