Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Copilot Chat UI bugs #981

Merged
merged 7 commits into from
May 13, 2023

Conversation

teresaqhoang
Copy link
Contributor

Motivation and Context

This PR contains CSS clean-up and fixes for a number of UI bugs.

Changes include:

  • ChatWindow no longer overflows out of window view
  • Scrollbars show up as necessary in ChatHistory and ChatList
    image
  • Check for valid .env file on start, error screen showed if variables aren't populated.

glahaye
glahaye previously approved these changes May 12, 2023
amsacha
amsacha previously approved these changes May 12, 2023
hathind-ms
hathind-ms previously approved these changes May 12, 2023
@hathind-ms hathind-ms enabled auto-merge (squash) May 12, 2023 23:59
@teresaqhoang teresaqhoang dismissed stale reviews from hathind-ms, amsacha, and glahaye via 17eaa7f May 13, 2023 00:58
@hathind-ms hathind-ms merged commit 16b0083 into microsoft:main May 13, 2023
@teresaqhoang teresaqhoang deleted the squashing-ui-bugs branch May 15, 2023 16:58
shawncal pushed a commit to johnoliver/semantic-kernel that referenced this pull request May 19, 2023
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
This PR contains CSS clean-up and fixes for a number of UI bugs.

Changes include: 
- ChatWindow no longer overflows out of window view
- Scrollbars show up as necessary in ChatHistory and ChatList

![image](https://github.com/microsoft/semantic-kernel/assets/125500434/d87f4f7f-f01d-49c1-ace6-bcc11ed3984d)
- Check for valid .env file on start, error screen showed if variables
aren't populated.
-
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
This PR contains CSS clean-up and fixes for a number of UI bugs.

Changes include: 
- ChatWindow no longer overflows out of window view
- Scrollbars show up as necessary in ChatHistory and ChatList

![image](https://github.com/microsoft/semantic-kernel/assets/125500434/d87f4f7f-f01d-49c1-ace6-bcc11ed3984d)
- Check for valid .env file on start, error screen showed if variables
aren't populated.
-
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants