Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Fix bot icons #975

Merged
merged 2 commits into from
May 12, 2023

Conversation

Vivihung
Copy link
Member

@Vivihung Vivihung commented May 12, 2023

Motivation and Context

Fix bot icons based on the UX design.
Note: We will need another fix to show the hexagon shape of the bot icon.

image

Description

Change how we refer to image in the client code.

Contribution Checklist

@adrianwyatt adrianwyatt enabled auto-merge (squash) May 12, 2023 17:37
@adrianwyatt adrianwyatt added PR: ready for review All feedback addressed, ready for reviews PR: ready to merge PR has been approved by all reviewers, and is ready to merge. and removed PR: ready for review All feedback addressed, ready for reviews labels May 12, 2023
@adrianwyatt adrianwyatt merged commit 99ee28d into microsoft:main May 12, 2023
@Vivihung Vivihung deleted the vivi/cc-bot-icon-fix branch May 18, 2023 18:14
shawncal pushed a commit to johnoliver/semantic-kernel that referenced this pull request May 19, 2023
### Motivation and Context
Fix bot icons based on the UX design. 
Note: We will need another fix to show the hexagon shape of the bot
icon.


![image](https://github.com/microsoft/semantic-kernel/assets/4814277/5c038199-7079-44c8-a21a-dbe4fa92834d)


### Description
Change how we refer to image in the client code.
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
### Motivation and Context
Fix bot icons based on the UX design. 
Note: We will need another fix to show the hexagon shape of the bot
icon.


![image](https://github.com/microsoft/semantic-kernel/assets/4814277/5c038199-7079-44c8-a21a-dbe4fa92834d)


### Description
Change how we refer to image in the client code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants