Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Qdrant, CosmosDB, Speech Services optional in deployment templates #969

Merged
merged 8 commits into from
May 13, 2023
Merged

Make Qdrant, CosmosDB, Speech Services optional in deployment templates #969

merged 8 commits into from
May 13, 2023

Conversation

glahaye
Copy link
Contributor

@glahaye glahaye commented May 12, 2023

Motivation and Context

We want to let users bring in their own memory or chat storage is they so wish. Similarly, we want to let users whether they want to deploy Speech services.

Description

Made Qdrant, CosmosDB, Speech Services optional in deployment templates by adding deployment template parameters.

Contribution Checklist

@glahaye glahaye changed the title Made Qdrant, CosmosDB, Speech Services optional in deployment templates Make Qdrant, CosmosDB, Speech Services optional in deployment templates May 12, 2023
@adrianwyatt adrianwyatt self-requested a review May 12, 2023 18:56
@adrianwyatt adrianwyatt added the PR: ready for review All feedback addressed, ready for reviews label May 12, 2023
Copy link
Member

@Vivihung Vivihung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will improve the deployment velocity if the dev already of the services deployed! thank you! Have a comment inline.

@glahaye
Copy link
Contributor Author

glahaye commented May 12, 2023

This will improve the deployment velocity if the dev already of the services deployed! thank you! Have a comment inline.

By default, bicep/ARM templates only deploy the elements which are not already present.

Vivihung
Vivihung previously approved these changes May 12, 2023
Copy link
Member

@Vivihung Vivihung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the explanation.

adrianwyatt
adrianwyatt previously approved these changes May 12, 2023
@adrianwyatt adrianwyatt enabled auto-merge (squash) May 12, 2023 22:39
@glahaye glahaye dismissed stale reviews from adrianwyatt and Vivihung via 3e2be48 May 12, 2023 22:55
@adrianwyatt adrianwyatt merged commit 1ae2f1d into microsoft:main May 13, 2023
shawncal pushed a commit to johnoliver/semantic-kernel that referenced this pull request May 19, 2023
…es (microsoft#969)

### Motivation and Context
We want to let users bring in their own memory or chat storage is they
so wish. Similarly, we want to let users whether they want to deploy
Speech services.

### Description
Made Qdrant, CosmosDB, Speech Services optional in deployment templates
by adding deployment template parameters.
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
…es (microsoft#969)

### Motivation and Context
We want to let users bring in their own memory or chat storage is they
so wish. Similarly, we want to let users whether they want to deploy
Speech services.

### Description
Made Qdrant, CosmosDB, Speech Services optional in deployment templates
by adding deployment template parameters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready for review All feedback addressed, ready for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants