Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net Agents - Fix Aggregator Streaming for Nested Mode #9669

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

crickman
Copy link
Contributor

Motivation and Context

Fixes: #8677

Aggretator agent not yielding content for streamed response when Mode=Nested.

Description

Analyzed and addressed behavior and added integration tests.

Contribution Checklist

@crickman crickman added bug Something isn't working PR: ready for review All feedback addressed, ready for reviews .NET Issue or Pull requests regarding .NET code experimental Associated with an experimental feature enhancement agents labels Nov 12, 2024
@crickman crickman self-assigned this Nov 12, 2024
@crickman crickman requested a review from a team as a code owner November 12, 2024 18:45
@markwallace-microsoft markwallace-microsoft added the kernel Issues or pull requests impacting the core kernel label Nov 12, 2024
@crickman crickman added this pull request to the merge queue Nov 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2024
@crickman crickman added this pull request to the merge queue Nov 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2024
@crickman crickman added this pull request to the merge queue Nov 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2024
@crickman crickman added this pull request to the merge queue Nov 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2024
@crickman crickman added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 4cd7f07 Nov 12, 2024
15 checks passed
@crickman crickman deleted the fix-agent-aggregator-streaming branch November 12, 2024 23:46
@crickman crickman removed the kernel Issues or pull requests impacting the core kernel label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents bug Something isn't working enhancement experimental Associated with an experimental feature .NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews
Projects
Status: Sprint: Done
Development

Successfully merging this pull request may close these issues.

.Net: Streaming Issue with AggregatorAgent in Nested Mode in version 1.19.0-alpha
4 participants