Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net Agents - Fix polling cycle to properly evaluate failure mode on exception #9581

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

crickman
Copy link
Contributor

@crickman crickman commented Nov 6, 2024

Motivation and Context

Assistant polling not propertly responding to terminal error conditions.

Fixes: #9579

Description

  • Added explicit check for cancelling state: Invoke, InvokeStreaming, & Polling loops
  • Discriminate on different exception modes when polling
  • Ensure stale run state isn't evaluated in polling loop
  • Remove initial polling delay

Contribution Checklist

@crickman crickman added PR: ready for review All feedback addressed, ready for reviews .NET Issue or Pull requests regarding .NET code experimental Associated with an experimental feature enhancement agents labels Nov 6, 2024
@crickman crickman self-assigned this Nov 6, 2024
@crickman crickman requested a review from a team as a code owner November 6, 2024 17:31
@crickman crickman added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 874ee95 Nov 6, 2024
15 checks passed
@crickman crickman deleted the fix-agent-assistant-polling branch November 6, 2024 20:11
@crickman crickman removed the PR: ready for review All feedback addressed, ready for reviews label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents enhancement experimental Associated with an experimental feature .NET Issue or Pull requests regarding .NET code
Projects
Status: Sprint: Done
Development

Successfully merging this pull request may close these issues.

.Net Agents - Ensure assistant agent exits run when thread deleted externally
3 participants