Fix error handling for OpenAI completion tests #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the error handling for the OpenAI completion tests by using the correct error codes and messages from the AIException class. It also adds a pragma warning to disable xUnit1004 for the file, since some of the tests are used for manual verification.
github-actions
bot
added
.NET
dmytrostruk
approved these changes
May 11, 2023
shawncal
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
May 19, 2023
This commit fixes the error handling for the OpenAI completion tests by using the correct error codes and messages from the AIException class. It also adds a pragma warning to disable xUnit1004 for the file, since some of the tests are used for manual verification.
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
This commit fixes the error handling for the OpenAI completion tests by using the correct error codes and messages from the AIException class. It also adds a pragma warning to disable xUnit1004 for the file, since some of the tests are used for manual verification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the error handling for the OpenAI completion tests by using the correct error codes and messages from the AIException class. It also adds a pragma warning to disable xUnit1004 for the file, since some of the tests are used for manual verification.
Contribution Checklist
dotnet format