Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Processes State Management Part 2 #9481

Merged

Conversation

esttenorio
Copy link
Contributor

@esttenorio esttenorio commented Oct 30, 2024

Description

  • Moving ProcessStateMetadata logic to factory/extension to try to keep clean existing core components
  • Adding check of step name when adding new steps/processes to process - names must be unique so when applying saved state it propagates properly. Currently there are issues if multiple steps have the same name
  • State versioning initial support:
    • Processes with 1:1 step match previous and new version (step name change and/or step logic change) - minor changes on process steps and not in root process itself

Fixing #9358

Out of scope but will be addressed in next PRs

  • Processes with N:M steps (process flow changed and potentially also step logic changed)
  • New samples showcasing how to make use of N:M mapping

Contribution Checklist

@markwallace-microsoft markwallace-microsoft added the .NET Issue or Pull requests regarding .NET code label Oct 30, 2024
@github-actions github-actions bot changed the title Processes State Management Part 2 .Net: Processes State Management Part 2 Oct 30, 2024
@crickman crickman self-requested a review November 4, 2024 18:43
@alliscode
Copy link
Member

I really like the centralized serialization logic. I'll be able to integrate this to the map-step change much more easily.

I like the depth with which the Step03 sample was updated, but I wonder if there isn't an opportunity for a more targeted starting point to introduce the serialization patterns. Demonstrating these patterns is a more real case is wonderful evidence on how these patterns scale-out...but I wonder if a more simple sample that only targets serialization and versioning would be useful.

I agree but I wonder if the learn site is the place for this tutorial style walkthrough?

@crickman
Copy link
Contributor

crickman commented Nov 4, 2024

I really like the centralized serialization logic. I'll be able to integrate this to the map-step change much more easily.
I like the depth with which the Step03 sample was updated, but I wonder if there isn't an opportunity for a more targeted starting point to introduce the serialization patterns. Demonstrating these patterns is a more real case is wonderful evidence on how these patterns scale-out...but I wonder if a more simple sample that only targets serialization and versioning would be useful.

I agree but I wonder if the learn site is the place for this tutorial style walkthrough?

Sure, or both

@esttenorio esttenorio added this pull request to the merge queue Nov 5, 2024
Merged via the queue into microsoft:main with commit a7a56e5 Nov 5, 2024
15 checks passed
@esttenorio esttenorio deleted the estenori/processes-state-management branch November 5, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation .NET Issue or Pull requests regarding .NET code processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants