Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: VectorStore: Allow any key when using a custom collection factory #9461

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

westey-m
Copy link
Contributor

Motivation and Context

If someone supplies a factory for constructing vector store record collections, this means that they may want to
use a decorator that changes the key type of the default record collection implementation.
This means that we shouldn't restrict the key types unless someone is using the default implementation.

Description

  • Remove check for key types for the case where someone supplied a record collection factory.

Contribution Checklist

@westey-m westey-m requested a review from a team as a code owner October 29, 2024 19:06
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel memory labels Oct 29, 2024
@github-actions github-actions bot changed the title VectorStore: Allow any key when using a custom collection factory .Net: VectorStore: Allow any key when using a custom collection factory Oct 29, 2024
@westey-m westey-m added this pull request to the merge queue Oct 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2024
@westey-m westey-m added this pull request to the merge queue Oct 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2024
@westey-m westey-m added this pull request to the merge queue Oct 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2024
@westey-m westey-m added this pull request to the merge queue Oct 30, 2024
Merged via the queue into microsoft:main with commit 82f7cbd Oct 30, 2024
18 checks passed
@westey-m westey-m deleted the vector-store-colfactkey branch October 30, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel memory .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants