Add support for non-static native functions with external references #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
dluc
force-pushed
the
dluc151nativefunctions
branch
from
4c651b1
to
fa80979
Compare
|
Please test thoroughly before merging. Unit tests should cover all the scenarios, but I would recommend testing manually gRPC, CoPilot chat and syntax examples. |
dluc
force-pushed
the
dluc151nativefunctions
branch
2 times, most recently
from
caf7f97
to
2be4487
Compare
shawncal
previously approved these changes
May 11, 2023
dluc
force-pushed
the
dluc151nativefunctions
branch
from
2be4487
to
98e9a67
Compare
dluc
force-pushed
the
dluc151nativefunctions
branch
from
98e9a67
to
f3012c4
Compare
lemillermicrosoft
previously approved these changes
May 11, 2023
adrianwyatt
previously approved these changes
May 11, 2023
|
"Could not load file or assembly 'Microsoft.Bcl.AsyncInterfaces, Version=7.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51" pops up in CopilotChat and the KernelSyntaxExamples. Looking for a good place to add the NuGet... |
Fixing with #955 |
adrianwyatt
approved these changes
May 11, 2023
shawncal
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
May 19, 2023
…icrosoft#937) ### Motivation and Context When registering local functions that reference external variables (gRPC scenario) SKFunction throws an exception because `Delegate.CreateDelegate` returns NULL. ### Description Fix the delegate type detection to support the case of non-static functions referencing external functions + Unit tests. --------- Co-authored-by: Adrian Bonar <[email protected]> Co-authored-by: Adrian Bonar (HE/HIM) <[email protected]>
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
…icrosoft#937) ### Motivation and Context When registering local functions that reference external variables (gRPC scenario) SKFunction throws an exception because `Delegate.CreateDelegate` returns NULL. ### Description Fix the delegate type detection to support the case of non-static functions referencing external functions + Unit tests. --------- Co-authored-by: Adrian Bonar <[email protected]> Co-authored-by: Adrian Bonar (HE/HIM) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When registering local functions that reference external variables (gRPC scenario) SKFunction throws an exception because
Delegate.CreateDelegatereturns NULL.Description
Fix the delegate type detection to support the case of non-static functions referencing external functions + Unit tests.