Fix dotnet graph-api-skills sample #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
MGudgin
force-pushed
the
gudge/fix_msgraph_sample
branch
2 times, most recently
from
308b27c
to
faff5cc
Compare
dluc
reviewed
May 10, 2023
MGudgin
force-pushed
the
gudge/fix_msgraph_sample
branch
2 times, most recently
from
9452020
to
247223a
Compare
The skillParentDirectory local used to find the SummarizeSkill in the graph-api-skills sample had one too few levels of directory navigation, resulting in a DirectoryNotFoundException. Initialize variable using RepoFiles.SampleSkillsPath from kernel-syntax-examples project. Reference kernel-syntax-examples project. Make RepoFiles class and SampleSkillsPath method public in kernal-syntax-examples. Add namespace to graph-api-skills/Program.cs to avoid type collision with Program class in kernel-syntax-examples project.
MGudgin
force-pushed
the
gudge/fix_msgraph_sample
branch
from
c7b351f
to
f3dc67f
Compare
adrianwyatt
added
the
PR: ready for review
adrianwyatt
requested changes
May 15, 2023
adrianwyatt
added
PR: feedback to address
adrianwyatt
approved these changes
May 19, 2023
adrianwyatt
added
PR: ready to merge
shawncal
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
May 19, 2023
The skillParentDirectory local used to find the SummarizeSkill in the graph-api-skills sample had one too few levels of directory navigation, resulting in a DirectoryNotFoundException. Initialize variable using RepoFiles.SampleSkillsPath from kernel-syntax-examples project. Reference kernel-syntax-examples project. Make RepoFiles class and SampleSkillsPath method public in kernel-syntax-examples. Add namespace to graph-api-skills/Program.cs to avoid type collision with Program class in kernel-syntax-examples project. Co-authored-by: Adrian Bonar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The skillParentDirectory local used to find the SummarizeSkill in the
graph-api-skills sample had one too few levels of directory navigation,
resulting in a DirectoryNotFoundException.
Initialize variable using RepoFiles.SampleSkillsPath from
kernel-syntax-examples project.
Reference kernel-syntax-examples project.
Make RepoFiles class and SampleSkillsPath method public in
kernel-syntax-examples.
Add namespace to graph-api-skills/Program.cs to avoid type collision
with Program class in kernel-syntax-examples project.