.Net: Processes - Sample Pattern Adjustments #9181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Noticed some tiny stuff I wanted to make available for review, separate from the Agent sample.
Description
LocalKernelProcessContext
isIDisposable
- Update to incorporateusing
statement to ensure disposal (best practice)Console.Write
not resulting any output (`TextWriter.Write(char value) is an empty virtual method that requires override...or in this case interception - https://github.com/microsoft/referencesource/blob/master/mscorlib/system/io/textwriter.cs#L193.)ScriptedUserInputStep
abstraction. State is never null and can be treated as such with a minor tweak. (Null check in the sample could be misleading - it gave me momentary pause)CreateKernelWithChatCompletion
method where present (already in base class)Step01_Processes.ChatBotState
initialization. The conditional inner initialization might be slightly misleading (It gave me momentary pause).Contribution Checklist