Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Improve mapper effeciency for pinecone and redis hashsets. #9064

Conversation

westey-m
Copy link
Contributor

@westey-m westey-m commented Oct 2, 2024

Motivation and Context

Originally we optimized for flexibility when mapping from storage to data models, but this comes at a cost of efficiency.

#9025

Description

  • Updating Redis HashSets and Pinecone mappers to not use Json as an intermediary
  • Adding restrictions around the types of enumerables supported and that the data model needs a public parameterless constructor.

Contribution Checklist

@westey-m westey-m requested a review from a team as a code owner October 2, 2024 16:59
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel memory labels Oct 2, 2024
@github-actions github-actions bot changed the title Improve mapper effeciency for pinecone and redis hashsets. .Net: Improve mapper effeciency for pinecone and redis hashsets. Oct 2, 2024
@westey-m westey-m added this pull request to the merge queue Oct 4, 2024
Merged via the queue into microsoft:main with commit c2b7f70 Oct 4, 2024
15 checks passed
@westey-m westey-m deleted the vector-store-mapping-efficiency-redishash-pinecone branch October 4, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel memory .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants