.Net: Gemini - Removed limitation when gemini throws exception if invalid response (BREAKING CHANGE) #8584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
RogerBarreto
temporarily deployed
to
integration
GitHub Actions
Inactive
RogerBarreto
approved these changes
Sep 13, 2024
RogerBarreto
temporarily deployed
to
integration
GitHub Actions
Inactive
westey-m
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Sometimes Gemini returns just empty json (or only prefix) without content and metadata.
Currently connector throws exception in such cases, but users complain about that behavior so I decided to not throw any exception and return an empty chat message.
Description
BREAKING CHANGE
Instead of throwing exceptions when there is nothing in response from the server, the connector simply ignores it by returning an empty chat message.
Because gemini connector is still alpha I haven't introduced a switch to disable this change.
@RogerBarreto
Contribution Checklist