-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: support all auth options for azure ai search #8495
Python: support all auth options for azure ai search #8495
Conversation
Python Test Coverage Report
Python Unit Test Overview
|
Hey @markwallace-microsoft! First time contributing here and trying to navigate the process. Do you think its worth to add tests for this change? I didnt find specific tests for that file. Also please let me know if I missed anything on how it works. My guess is that we just need to add these classes and it will automatically use the new options when calling openAI |
Would be good to validate the validation that happens with a test, can be part of the |
...rnel/connectors/ai/open_ai/prompt_execution_settings/azure_chat_prompt_execution_settings.py
Outdated
Show resolved
Hide resolved
@moonbox3 Could you please take another look? I reverted the change on the ApiKey parameter (to make the key required) |
@eavanvalkenburg I noticed 2 approvals are required, could you please take a look as well? |
303b6d0
to
88e5d02
Compare
Motivation and Context
Description
Azure AI Search data source supports 4 types of authentication but semantic kernel only supports
ApiKey
api key.This PR adds support to the other authentication options as defined in its docs, which are
Contribution Checklist