-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Fix agent group chat bug related to function calling in ChatCompletionAgent #8330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
Pull requests for the Python Semantic Kernel
label
Aug 22, 2024
TaoChenOSU
approved these changes
Aug 22, 2024
crickman
reviewed
Aug 22, 2024
Python Test Coverage Report
Python Unit Test Overview
|
juliomenendez
approved these changes
Aug 22, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
…ompletionAgent (microsoft#8330) ### Motivation and Context During a group chat, if using an OpenAIAssistantAgent, the addition of a ChatCompletionMessage to the AssistantAgent channel was breaking because we were including FunctionCallContent. Additionally, there needs to be some translation of a FunctionResultContent type to a text type when adding a ChatCompletionAgent message to an AssistantAgent thread message. The AuthorRole can only be 'user' or 'assistant'. <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description Fixes for the items mentioned above. This may not be a perfect solution, but getting this in and I can revisit it to align more closely with how dotnet handles the FunctionResultContent/TextContent as part of the overall ChatMessageContent. - This PR also adds a new sample showing mixed agent chat and a ChatCompletionAgent using plugins. <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
During a group chat, if using an OpenAIAssistantAgent, the addition of a ChatCompletionMessage to the AssistantAgent channel was breaking because we were including FunctionCallContent. Additionally, there needs to be some translation of a FunctionResultContent type to a text type when adding a ChatCompletionAgent message to an AssistantAgent thread message. The AuthorRole can only be 'user' or 'assistant'.
Description
Fixes for the items mentioned above. This may not be a perfect solution, but getting this in and I can revisit it to align more closely with how dotnet handles the FunctionResultContent/TextContent as part of the overall ChatMessageContent.
Contribution Checklist