-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Introduce Agent group chat functionality #8184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
python
Pull requests for the Python Semantic Kernel
documentation
labels
Aug 15, 2024
Python Test Coverage Report
Python Unit Test Overview
|
crickman
reviewed
Aug 15, 2024
python/samples/getting_started_with_agents/resources/assistant_file_search/travelinfo.txt
Outdated
Show resolved
Hide resolved
crickman
reviewed
Aug 15, 2024
python/semantic_kernel/agents/open_ai/open_ai_assistant_base.py
Outdated
Show resolved
Hide resolved
crickman
reviewed
Aug 15, 2024
alliscode
reviewed
Aug 15, 2024
python/samples/getting_started_with_agents/step4_kernel_function_strategies.py
Show resolved
Hide resolved
alliscode
reviewed
Aug 15, 2024
python/samples/getting_started_with_agents/step8_assistant_vision.py
Outdated
Show resolved
Hide resolved
alliscode
approved these changes
Aug 15, 2024
TaoChenOSU
approved these changes
Aug 15, 2024
eavanvalkenburg
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small note, not blocking! awesome stuff!
python/semantic_kernel/agents/open_ai/assistant_content_generation.py
Outdated
Show resolved
Hide resolved
eavanvalkenburg
approved these changes
Aug 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 19, 2024
eavanvalkenburg
approved these changes
Aug 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 19, 2024
eavanvalkenburg
approved these changes
Aug 19, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Motivation and Context In the next phase of the agent work in Python, we are to introduce the ability to have agents interact with each other. Agent group chat allows developers to create richer and more dynamic agent interactions. <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description This PR introduces the following: - Agent group chat functionality via an `agent_chat` base class that forms the foundation for group chats. An `agent_group_chat` class extends that underlying functionality and provides an entry point to kick off the group chat either via invoking the chat for the defined agents, or specifying if a provided agent is to join the existing chat. - The required channels for the chat completion agent and assistant agent to properly chat together - Adds more concept samples and getting started with agent samples to enrich the onboarding experiencing for those wanting to see the capability of agents and agent group chat. - Adds unit test for near 100% coverage - Updates some existing imports for agents, which try and make the required import experience more intuitive. - Introduces assistant agent abstractions for working with files and vector stores so we don't directly expose the underlying client types. - Closes microsoft#7966 - Closes microsoft#7577 <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In the next phase of the agent work in Python, we are to introduce the ability to have agents interact with each other. Agent group chat allows developers to create richer and more dynamic agent interactions.
Description
This PR introduces the following:
agent_chat
base class that forms the foundation for group chats. Anagent_group_chat
class extends that underlying functionality and provides an entry point to kick off the group chat either via invoking the chat for the defined agents, or specifying if a provided agent is to join the existing chat.Contribution Checklist