Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Introduce Agent group chat functionality #8184

Merged
merged 36 commits into from
Aug 19, 2024

Conversation

moonbox3
Copy link
Contributor

Motivation and Context

In the next phase of the agent work in Python, we are to introduce the ability to have agents interact with each other. Agent group chat allows developers to create richer and more dynamic agent interactions.

Description

This PR introduces the following:

  • Agent group chat functionality via an agent_chat base class that forms the foundation for group chats. An agent_group_chat class extends that underlying functionality and provides an entry point to kick off the group chat either via invoking the chat for the defined agents, or specifying if a provided agent is to join the existing chat.
  • The required channels for the chat completion agent and assistant agent to properly chat together
  • Adds more concept samples and getting started with agent samples to enrich the onboarding experiencing for those wanting to see the capability of agents and agent group chat.
  • Adds unit test for near 100% coverage
  • Updates some existing imports for agents, which try and make the required import experience more intuitive.
  • Introduces assistant agent abstractions for working with files and vector stores so we don't directly expose the underlying client types.
  • Closes Python Agents - Add samples for step 9 -12 to GettingStartedWithAgents #7966
  • Closes Python: implement agent group chat functionality #7577

Contribution Checklist

@moonbox3 moonbox3 requested a review from a team as a code owner August 15, 2024 17:10
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel documentation labels Aug 15, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Aug 15, 2024

Python Test Coverage

Python Test Coverage Report
FileStmtsMissCoverMissing
semantic_kernel
   kernel.py1994776%150, 161, 165, 315–318, 425, 439–482
semantic_kernel/agents/group_chat
   agent_chat.py108199%91
   agent_group_chat.py67297%113, 135
   broadcast_queue.py72199%35
semantic_kernel/agents/open_ai
   open_ai_assistant_base.py361399%243, 321–322
semantic_kernel/connectors/ai/anthropic/services
   anthropic_chat_completion.py942573%171–181, 196–205, 222–236
semantic_kernel/connectors/ai/azure_ai_inference/services
   azure_ai_inference_chat_completion.py149398%170, 320, 436
semantic_kernel/connectors/ai/embeddings
   embedding_generator_base.py8188%50
semantic_kernel/connectors/ai/google
   shared_utils.py39295%97, 119
semantic_kernel/connectors/ai/google/google_ai/services
   google_ai_chat_completion.py148398%151, 263, 297
   utils.py63395%139, 157–162
semantic_kernel/connectors/ai/google/vertex_ai/services
   utils.py65395%141, 159–164
   vertex_ai_chat_completion.py148398%145, 256, 290
semantic_kernel/connectors/ai/hugging_face/services
   hf_text_completion.py54394%97, 105, 136
   hf_text_embedding.py32584%79–83
semantic_kernel/connectors/memory/azure_ai_search
   azure_ai_search_collection.py87298%150, 152
semantic_kernel/connectors/memory/redis
   redis_collection.py160299%146, 316
   utils.py451176%145–146, 164, 166, 173–188
semantic_kernel/connectors/openapi_plugin
   openapi_manager.py58297%110–111
   openapi_parser.py88199%127
   openapi_runner.py105298%181–182
semantic_kernel/connectors/openapi_plugin/models
   rest_api_operation.py129199%242
semantic_kernel/contents
   function_call_content.py97199%201
semantic_kernel/data
   vector_store_record_collection.py2491992%410, 470–474, 482–486, 526–529, 536–539
   vector_store_record_utils.py26292%50, 52
semantic_kernel/functions
   kernel_function_decorator.py98199%102
   kernel_function_from_method.py96199%153
   kernel_function_from_prompt.py154795%165–166, 180, 201, 219, 239, 322
   kernel_plugin.py187299%472, 475
semantic_kernel/planners
   plan.py2344581%54, 163–165, 197, 214–227, 264, 269, 277–278, 288–291, 308, 313, 329, 332–337, 355, 360, 363, 365, 372, 386–388, 393–397
semantic_kernel/planners/function_calling_stepwise_planner
   function_calling_stepwise_planner.py116497%145, 189–190, 198
semantic_kernel/planners/sequential_planner
   sequential_planner.py64691%71, 75, 109, 125, 134–135
   sequential_planner_extensions.py50982%31–32, 56, 110–124
   sequential_planner_parser.py771284%66–74, 93, 117–120
semantic_kernel/schema
   kernel_json_schema_builder.py119596%50, 84, 206, 210–211
semantic_kernel/template_engine/blocks
   code_block.py77199%119
   named_arg_block.py43198%98
semantic_kernel/utils/telemetry
   decorators.py113496%232, 240, 243, 252
   user_agent.py16288%18–19
TOTAL1066824898% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
2367 1 💤 0 ❌ 0 🔥 52.482s ⏱️

Copy link
Member

@eavanvalkenburg eavanvalkenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small note, not blocking! awesome stuff!

@moonbox3 moonbox3 added this pull request to the merge queue Aug 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 19, 2024
@moonbox3 moonbox3 added this pull request to the merge queue Aug 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 19, 2024
@moonbox3 moonbox3 added this pull request to the merge queue Aug 19, 2024
Merged via the queue into microsoft:main with commit ee40e88 Aug 19, 2024
25 checks passed
@moonbox3 moonbox3 deleted the agent_chat branch August 19, 2024 18:15
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this pull request Aug 25, 2024
### Motivation and Context

In the next phase of the agent work in Python, we are to introduce the
ability to have agents interact with each other. Agent group chat allows
developers to create richer and more dynamic agent interactions.

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

This PR introduces the following:
- Agent group chat functionality via an `agent_chat` base class that
forms the foundation for group chats. An `agent_group_chat` class
extends that underlying functionality and provides an entry point to
kick off the group chat either via invoking the chat for the defined
agents, or specifying if a provided agent is to join the existing chat.
- The required channels for the chat completion agent and assistant
agent to properly chat together
- Adds more concept samples and getting started with agent samples to
enrich the onboarding experiencing for those wanting to see the
capability of agents and agent group chat.
- Adds unit test for near 100% coverage
- Updates some existing imports for agents, which try and make the
required import experience more intuitive.
- Introduces assistant agent abstractions for working with files and
vector stores so we don't directly expose the underlying client types.
- Closes microsoft#7966 
- Closes microsoft#7577

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents documentation python Pull requests for the Python Semantic Kernel
Projects
Archived in project
6 participants