Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: OpenAI V2 - Small fix #8015

Merged
merged 1 commit into from
Aug 9, 2024
Merged

.Net: OpenAI V2 - Small fix #8015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions dotnet/src/Connectors/Connectors.OpenAI/Core/ClientCore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,5 @@
// Copyright (c) Microsoft. All rights reserved.

/*
Phase 01 : This class was created adapting and merging ClientCore and OpenAIClientCore classes.
System.ClientModel changes were added and adapted to the code as this package is now used as a dependency over OpenAI package.
All logic from original ClientCore and OpenAIClientCore were preserved.

Phase 02 :
- Moved AddAttributes usage to the constructor, avoiding the need verify and adding it in the services.
- Added ModelId attribute to the OpenAIClient constructor.
- Added WhiteSpace instead of empty string for ApiKey to avoid exception from OpenAI Client on custom endpoints added an issue in OpenAI SDK repo. https://github.com/openai/openai-dotnet/issues/90

Phase 05:
- Model Id became not be required to support services like: File Service.

*/

using System;
using System.ClientModel;
using System.ClientModel.Primitives;
Expand Down
Loading