-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Json schema improvements for Union and Optional #7367
Merged
eavanvalkenburg
merged 8 commits into
microsoft:main
from
moonbox3:json_schema_improvements
Jul 23, 2024
Merged
Python: Json schema improvements for Union and Optional #7367
eavanvalkenburg
merged 8 commits into
microsoft:main
from
moonbox3:json_schema_improvements
Jul 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaoChenOSU
approved these changes
Jul 19, 2024
markwallace-microsoft
added
the
python
Pull requests for the Python Semantic Kernel
label
Jul 22, 2024
eavanvalkenburg
approved these changes
Jul 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 22, 2024
TaoChenOSU
approved these changes
Jul 22, 2024
Python 3.10 Test Coverage Report
Python 3.10 Unit Test Overview
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 22, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Motivation and Context We have some gaps in how we build the JSON schema for function calling related to Union and Optional types. There is also some work to do related to handling `Optional` versus `param | None = None`. <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description This PR improves the JSON schema building for the Union and Optional types. It adds additional tests and improves some existing tests. - Closes microsoft#7297 - Closes microsoft#7298 <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We have some gaps in how we build the JSON schema for function calling related to Union and Optional types. There is also some work to do related to handling
Optional
versusparam | None = None
.Description
This PR improves the JSON schema building for the Union and Optional types. It adds additional tests and improves some existing tests.
Contribution Checklist