.Net Agents - Agent History Propagation #7216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crickman
added
.NET
crickman
changed the title
This was
linked to
issues
Jul 11, 2024
markwallace-microsoft
added
the
kernel
crickman
changed the title
crickman
changed the title
markwallace-microsoft
removed
kernel
crickman
changed the title
markwallace-microsoft
added
the
kernel
alliscode
reviewed
Jul 16, 2024
dotnet/samples/Concepts/Filtering/AutoFunctionInvocationFiltering.cs
Outdated
Show resolved
Hide resolved
alliscode
reviewed
Jul 16, 2024
alliscode
approved these changes
Jul 16, 2024
glahaye
changed the title
EdenTanami
reviewed
Jul 17, 2024
crickman
added
PR: ready for review
glahaye
approved these changes
Jul 17, 2024
crickman
removed
the
PR: ready for review
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Desired behavior: - Yield function-result when IAutoFunctionInvocationFilter terminates processing. - Include all function related content in primary chat history - Broadcast all function related content to agent channels ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Adds ability for agent channel to signal which messages are: - Visible to the primary message loop - Or, silently added to chat history Normally function related content exists only in the history, but when IAutoFunctionInvocationFilter terminates processing, the message with the `FunctionResultContent` is expected to visible in the primary message loop. Also fixed where mutated chat-history is captured for streaming case. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Desired behavior:
Description
Adds ability for agent channel to signal which messages are:
Normally function related content exists only in the history, but when IAutoFunctionInvocationFilter terminates processing, the message with the
FunctionResultContentis expected to visible in the primary message loop.Also fixed where mutated chat-history is captured for streaming case.
Contribution Checklist