.Net: Migrate AzureOpenAITextToAudioService to Azure.AI.OpenAI SDK v2 #7102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
...et/src/Connectors/Connectors.AzureOpenAI/Settings/AzureOpenAITextToAudioExecutionSettings.cs
Show resolved
Hide resolved
...et/src/Connectors/Connectors.AzureOpenAI/Settings/AzureOpenAITextToAudioExecutionSettings.cs
Show resolved
Hide resolved
...et/src/Connectors/Connectors.AzureOpenAI/Settings/AzureOpenAITextToAudioExecutionSettings.cs
Show resolved
Hide resolved
westey-m
reviewed
Jul 5, 2024
...et/src/Connectors/Connectors.AzureOpenAI/Settings/AzureOpenAITextToAudioExecutionSettings.cs
Show resolved
Hide resolved
westey-m
approved these changes
Jul 5, 2024
RogerBarreto
reviewed
Jul 5, 2024
...s/Connectors.AzureOpenAI.UnitTests/Extensions/AzureOpenAIServiceCollectionExtensionsTests.cs
Show resolved
Hide resolved
...onnectors.AzureOpenAI.UnitTests/Extensions/AzureOpenAIServiceKernelBuilderExtensionsTests.cs
Outdated
Show resolved
Hide resolved
...c/Connectors/Connectors.AzureOpenAI.UnitTests/Services/AzureOpenAITextToAudioServiceTests.cs
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.AzureOpenAI/Core/ClientCore.TextToAudio.cs
Show resolved
Hide resolved
...t/src/Connectors/Connectors.AzureOpenAI/Extensions/AzureOpenAIServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
...et/src/Connectors/Connectors.AzureOpenAI/Settings/AzureOpenAITextToAudioExecutionSettings.cs
Outdated
Show resolved
Hide resolved
...et/src/Connectors/Connectors.AzureOpenAI/Settings/AzureOpenAITextToAudioExecutionSettings.cs
Show resolved
Hide resolved
...et/src/Connectors/Connectors.AzureOpenAI/Settings/AzureOpenAITextToAudioExecutionSettings.cs
Show resolved
Hide resolved
This was referenced Jul 5, 2024
RogerBarreto
approved these changes
Jul 5, 2024
SergeyMenshykh
merged commit b458a74
into
microsoft:feature-connectors-openai
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR migrates AzureOpenAITextToAudioService to Azure.AI.OpenAI SDK v2.
Description
AzureOpenAITextToAudioExecutionSettingsclass is added to represent prompt execution settings forAzureOpenAITextToAudioService. BothAzureOpenAITextToAudioServiceclasses that SK has today use the same prompt execution settings class - OpenAITextToAudioExecutionSettings. This is a breaking change that is tracked in the issue - .Net: AzureOpenAI migration breaking changes #7053, and it will be decided later whether to proceed with the change or roll it back.ClientCore.TextToAudio.csclass is refactored to use the newAzureOpenAITextToAudioExecutionSettingsclass.ClientCore.TextToAudio.csclass is refactored to decide which model id to use - the one from the prompt execution setting, the one supplied when registering the connector, or to use the deployment name if no model id is provided. This is done for backward compatibility with the existingAzureOpenAITextToAudioService. .Net: Revise ModelId/DeploymentName fallback logic for the AzureOpenAITextToAudioService #7104