.Net: Allow custom serialization options to be passed to TextMemoryPlugin. #7098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o allow non-latin script to be serialized without escaping.
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
SergeyMenshykh
approved these changes
Jul 4, 2024
4 tasks
markwallace-microsoft
approved these changes
Jul 4, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
…ugin. (microsoft#7098) ### Motivation and Context When `TextMemoryPlugin` gets back multiple results from the memory store during recall, it uses json serialization to turn these multiple results into a single string. In some cases, this may cause unintended side-affects, e.g. when non-latin script is present in the results, `JsonSerializer` automatically escapes these characters. Adding support for passing custom `JsonSerializerOptions` into the `TextMemoryPlugin` to customize the serialization behavior. See microsoft#6593 ### Description Added optional `JsonSerializerOptions` to the `TextMemoryPlugin` constructor. Added example to demonstrate this scenario. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When
TextMemoryPlugingets back multiple results from the memory store during recall, it uses json serialization toturn these multiple results into a single string.
In some cases, this may cause unintended side-affects, e.g. when non-latin script is present in the results,
JsonSerializerautomatically escapes these characters.Adding support for passing custom
JsonSerializerOptionsinto theTextMemoryPluginto customize the serialization behavior.See #6593
Description
Added optional
JsonSerializerOptionsto theTextMemoryPluginconstructor.Added example to demonstrate this scenario.
Contribution Checklist