Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Small docstring fix #5741

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

nickwalkmsft
Copy link
Member

Motivation and Context

This is a single-line fix to a Python docstring to get it to conform to Sphinx standards and convention used elsewhere in the project.

(My team owns the reference docs generation process for this and other libraries. We forced a build the other day from our side for test purposes and noticed it stumbled over this line. Feel free to ping me if any questions.)

Description

See changes, it's a one-liner 😁

Contribution Checklist

I ashamedly admit I have done none of the below; hopefully this is a gimme, apologies if it creates noise.

Small fix to docstring to conform to standards.
@nickwalkmsft nickwalkmsft requested a review from a team as a code owner April 2, 2024 21:21
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Apr 2, 2024
@github-actions github-actions bot changed the title Small docstring fix Python: Small docstring fix Apr 2, 2024
@markwallace-microsoft
Copy link
Member

Py3.8 Test Coverage

Python 3.8 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL5561102382% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.8 Unit Test Overview

Tests Skipped Failures Errors Time
1207 11 💤 0 ❌ 0 🔥 1m 21s ⏱️

@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 3, 2024
Merged via the queue into microsoft:main with commit 3437683 Apr 3, 2024
31 checks passed
@nickwalkmsft nickwalkmsft deleted the patch-1 branch April 3, 2024 14:21
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this pull request Aug 25, 2024
### Motivation and Context

This is a single-line fix to a Python docstring to get it to conform to
Sphinx standards and convention used
[elsewhere](https://github.com/microsoft/semantic-kernel/blob/20304f38fed9730f258acbdf59bad898ac809952/python/semantic_kernel/planners/plan.py#L137)
in the project.

(My team owns the reference docs generation process for this and other
libraries. We forced a build the other day from our side for test
purposes and noticed it stumbled over this line. Feel free to ping me if
any questions.)

### Description

See changes, it's a one-liner 😁

### Contribution Checklist

I ashamedly admit I have done *none* of the below; hopefully this is a
gimme, apologies if it creates noise.

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants