.Net Added support for gemini-vision #4957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Gemini request creation process has been refactored to include support for ImageContent. At present, the support extends to Uri files and is only available in VertexAI. The associated unit tests have been updated to reflect these changes.
shawncal
added
.NET
21 tasks
RogerBarreto
approved these changes
Feb 12, 2024
RogerBarreto
merged commit 2cb5ae1
into
microsoft:feature-connectors-gemini
13 checks passed
Krzysztof318
added a commit
to Krzysztof318/semantic-kernel
that referenced
this pull request
Feb 15, 2024
### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> State of connector progress microsoft#4680 This PR introduces limited support for ImageContent. At present, the support extends to only Uri files and is only available in VertexAI. The associated unit tests have been updated to reflect these changes. @RogerBarreto ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Krzysztof318
added a commit
to Krzysztof318/semantic-kernel
that referenced
this pull request
Feb 20, 2024
### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> State of connector progress microsoft#4680 This PR introduces limited support for ImageContent. At present, the support extends to only Uri files and is only available in VertexAI. The associated unit tests have been updated to reflect these changes. @RogerBarreto ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
has no option ImageContent(uri, mimeType) ??? |
|
@apipino Mime type is specified only for binary daty passes via base64. I didn't tested gemini models with url images because that wasn't possible when I was creating the connector. Please create new issue for that and mark me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
State of connector progress #4680
This PR introduces limited support for ImageContent. At present, the support extends to only Uri files and is only available in VertexAI. The associated unit tests have been updated to reflect these changes.
@RogerBarreto
Contribution Checklist