-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: chat-summary-webapp-react - change label for deployment form input from Model to Deployment #1368
Merged
lemillermicrosoft
merged 7 commits into
microsoft:main
from
mattmazzola:mattm/azureopenai-deployment-name
Jun 8, 2023
Merged
style: chat-summary-webapp-react - change label for deployment form input from Model to Deployment #1368
lemillermicrosoft
merged 7 commits into
microsoft:main
from
mattmazzola:mattm/azureopenai-deployment-name
Jun 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrostruk
reviewed
Jun 8, 2023
dmytrostruk
added
the
PR: ready for review
All feedback addressed, ready for reviews
label
Jun 8, 2023
dmytrostruk
previously approved these changes
Jun 8, 2023
@lemillermicrosoft I think we can merge this one, although I'm not sure why Spell Check is failing specifically in this PR. |
Yea, I'm not sure how that code was merged in before if the check fails. I see
I updated to also fix the typo since it was another simple string change |
mattmazzola
commented
Jun 8, 2023
5 tasks
lemillermicrosoft
approved these changes
Jun 8, 2023
lemillermicrosoft
added a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 8, 2023
commit d3775b0 Author: Matt Mazzola <[email protected]> Date: Thu Jun 8 12:43:17 2023 -0700 style: chat-summary-webapp-react - change label for deployment form input from Model to Deployment (microsoft#1368) There are different sets of parameters when using OpenAI vs Azure OpenAI 1. OpenAI Key 1. Model (`text-davinci-003`) You can deploy multiple versions of the same model (`gpt-3.5-turbo`) with different resource throughput. This is why "model" is not unique enough. Instead of Model you specify Deployment and Endpoint 1. OpenAI Key 1. Deployment 1. Endpoint The `samples\apps\chat-summary-webapp-react` it was using Model term which may be misleading - samples\apps\chat-summary-webapp-react - Change label for Deployment form input from Model to Deployment commit 1a7639a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jun 8 18:13:30 2023 +0000 Bump PdfPig from 0.1.8-alpha-20230423-3898f to 0.1.8-alpha-20230529-6daa2 in /dotnet (microsoft#1267) Bumps [PdfPig](https://github.com/UglyToad/PdfPig) from 0.1.8-alpha-20230423-3898f to 0.1.8-alpha-20230529-6daa2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/UglyToad/PdfPig/releases">PdfPig's releases</a>.</em></p> <blockquote> <h2>0.1.2 Second Alpha</h2> <p>Adds letter font details and a couple of other bugfixes to the alpha version.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/UglyToad/PdfPig/commits">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=PdfPig&package-manager=nuget&previous-version=0.1.8-alpha-20230423-3898f&new-version=0.1.8-alpha-20230529-6daa2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adrian Bonar <[email protected]> commit 729d9d7 Author: garethdebruyn <[email protected]> Date: Thu Jun 8 19:47:22 2023 +0200 Update Example02_Pipeline.cs (microsoft#1286) text["LStrip"], text["RStrip"] no longer seem to be part of TextSkill commit de74668 Author: Lee Miller <[email protected]> Date: Thu Jun 8 10:41:02 2023 -0700 Fixing typos (microsoft#1377) Fixing typos to unblock PRs. commit 3bc0967 Author: Roger Barreto <[email protected]> Date: Thu Jun 8 17:29:52 2023 +0100 IChatCompletion Multiple Results / New Interfaces (microsoft#1117) Add potential for IChatCompletion with multiple results per prompt. ![MultiChatResultPR](https://github.com/microsoft/semantic-kernel/assets/19890735/725ecce9-5e22-4a46-a06d-b159c68807f0) - Adds new Interfaces/Abstractions for Chat Results: `IChatResult`, `IChatStreamingResult`, `IChatMessage` - Adds new `IChatCompletion` interface methods for Streaming and Non-Streaming results - Moves old `IChatCompletion` interface methods `IAsyncEnumerable<string> GenerateMessageStreamAsync` and `Task<string> GenerateMessageAsync` as extensions for retro compatibility - Changed `ChatAsText` to use the new multiple results implementations - Makes `ChatHistory.ChatMessage` & `ChatHistory.AuthorsRole` types obsolete (discouraging usage of those implementation in favor of new `IChatMessage` - `ChatHistory` abstraction now extends from `List<IChatMessage>` - Updates all Samples using the new interfaces. - Remove `ChatHistory.ChatMessage` inner class - Remove `ChatHistory.AuthorsRole` enums - Make `ChatHistory` an abstract class or an `IChatHistory` interface. - Rename `ITextCompletionResult` to `ITextResult` - Rename `ITextComplet
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…nput from Model to Deployment (microsoft#1368) ### Motivation and Context There are different sets of parameters when using OpenAI vs Azure OpenAI #### OpenAI 1. OpenAI Key 1. Model (`text-davinci-003`) #### Azure OpenAI You can deploy multiple versions of the same model (`gpt-3.5-turbo`) with different resource throughput. This is why "model" is not unique enough. Instead of Model you specify Deployment and Endpoint 1. OpenAI Key 1. Deployment 1. Endpoint The `samples\apps\chat-summary-webapp-react` it was using Model term which may be misleading ### Description - samples\apps\chat-summary-webapp-react - Change label for Deployment form input from Model to Deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
There are different sets of parameters when using OpenAI vs Azure OpenAI
OpenAI
text-davinci-003
)Azure OpenAI
You can deploy multiple versions of the same model (
gpt-3.5-turbo
) with different resource throughput. This is why "model" is not unique enough. Instead of Model you specify Deployment and EndpointThe
samples\apps\chat-summary-webapp-react
it was using Model term which may be misleadingDescription
Contribution Checklist
dotnet format