Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Correct function name #1157

Merged
merged 4 commits into from
May 22, 2023
Merged

Python: Correct function name #1157

merged 4 commits into from
May 22, 2023

Conversation

riedgar-ms
Copy link
Contributor

Motivation and Context

In the Python BasicPlanner one of the examples has a 'translate' function, but doesn't quite reference it correctly in the JSON output.

Description

The overall approach is to make the various parts of the few-shot example in the prompt self-consistent.

Contribution Checklist

@riedgar-ms
Correct function name
4c6a82e 
Incorrect function name in the basic planner
@github-actions github-actions bot added the python Pull requests for the Python Semantic Kernel label May 22, 2023
@alexchaomander alexchaomander self-requested a review May 22, 2023 19:30
alexchaomander
alexchaomander approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@alexchaomander alexchaomander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you for fixing this!

@alexchaomander alexchaomander added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label May 22, 2023
@alexchaomander alexchaomander changed the title Correct function name Python: Correct function name May 22, 2023
@lemillermicrosoft lemillermicrosoft merged commit e9bb05e into microsoft:main May 22, 2023
@riedgar-ms riedgar-ms deleted the patch-1 branch May 22, 2023 21:01
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
@riedgar-ms
Python: Correct function name (microsoft#1157)
0a5c1f2 
### Motivation and Context
In the Python `BasicPlanner` one of the examples has a 'translate'
function, but doesn't quite reference it correctly in the JSON output.

### Description
The overall approach is to make the various parts of the few-shot
example in the prompt self-consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexchaomander alexchaomander alexchaomander approved these changes

@lemillermicrosoft lemillermicrosoft Awaiting requested review from lemillermicrosoft

Assignees
No one assigned
Labels
PR: ready to merge PR has been approved by all reviewers, and is ready to merge. python Pull requests for the Python Semantic Kernel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riedgar-ms @alexchaomander @lemillermicrosoft