Fix incorrect condition in QdrantMemoryStore.DeleteCollectionAsync #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
craigomatic
added
the
PR: ready for review
hathind-ms
approved these changes
May 17, 2023
|
Related #767 |
shawncal
approved these changes
May 17, 2023
shawncal
force-pushed
the
fix-qdrant-delete-bug
branch
from
bb71a93
to
f194d6a
Compare
shawncal
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
May 19, 2023
…icrosoft#1025) ### Motivation and Context Bug discovered over at microsoft#949 - this fixes the condition and updates the corresponding unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Bug discovered over at #949 - this fixes the condition and updates the corresponding unit test
Contribution Checklist
dotnet format