Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Adapt In-Memory Connector to new Text Search Design #6731

Open
2 tasks
markwallace-microsoft opened this issue Jun 17, 2024 · 0 comments · Fixed by #9046
Open
2 tasks

.Net: Adapt In-Memory Connector to new Text Search Design #6731

markwallace-microsoft opened this issue Jun 17, 2024 · 0 comments · Fixed by #9046
Assignees
@markwallace-microsoft
Labels
Ignite .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) text_search

Comments

@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Jun 17, 2024 •
edited
Loading

Text Search ADR is here: #5799

  • Integration tests
  • DI support
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code text_search labels Jun 17, 2024
@markwallace-microsoft markwallace-microsoft moved this to Backlog: Planned in Semantic Kernel Jun 17, 2024
@markwallace-microsoft markwallace-microsoft self-assigned this Aug 28, 2024
@markwallace-microsoft markwallace-microsoft moved this from Backlog: Planned to Sprint: Planned in Semantic Kernel Sep 5, 2024
@markwallace-microsoft markwallace-microsoft changed the title .Net: Update In-Memory Connector to new Text Search Design .Net: Adapt In-Memory Connector to new Text Search Design Oct 1, 2024
Merged
4 tasks
markwallace-microsoft added a commit that referenced this issue Oct 2, 2024
@markwallace-microsoft
.Net: Adapt In-Memory Connector to new Text Search Design (#9046)
2b94b08 
### Motivation and Context

Closes #6731 

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
@evchaki evchaki added the sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markwallace-microsoft markwallace-microsoft

Labels
Ignite .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) text_search
Projects
Semantic Kernel
Status: Sprint: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.Net: Adapt In-Memory Connector to new Text Search Design markwallace-microsoft/semantic-kernel
2 participants
@evchaki @markwallace-microsoft