-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Cannot get the value of a token type 'False' as a number when using Chroma Memory Store #2790
Comments
@paolosalvatori Good catch, thank you for creating this issue! This PR should resolve an issue: #2796 As part of my PR, I've updated notebook and Chroma README file to mention the latest Chroma version, which was used to verify Chroma connector and examples. I noticed that Chroma notebook also contains some obsolete code, which should be updated together with SK version upgrade. We will update it as soon as new SK version will be published, including PR mentioned above. Thanks again! |
…2796) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Resolves: #2790 This PR contains changes to update processing of boolean values in order to be compatible with Chroma 0.4.10. With new Chroma updates we need to update Chroma connector on regular basis to be compatible. The note has been added to Chroma notebook and README file to show the latest version of Chroma, which was used to verify the connector. In order to fix notebook to be compatible with latest version, the notebook should be updated as soon as this PR is released. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> 1. Removed `ChromaBooleanConverter` to be compatible with Chroma 0.4.10. 2. Added note with latest tested version of Chroma in notebook and README file. 3. Updated unit tests. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Thanks @dmytrostruk, will the fix ship in the next SK release? If yes, what is the ETA? |
@paolosalvatori Preview version of package with fix should be published to NuGet next Monday (18th September). But if you want to work with it earlier, we have nightly builds, the latest one was published 7 hours ago, which should include the fix: |
…icrosoft#2796) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Resolves: microsoft#2790 This PR contains changes to update processing of boolean values in order to be compatible with Chroma 0.4.10. With new Chroma updates we need to update Chroma connector on regular basis to be compatible. The note has been added to Chroma notebook and README file to show the latest version of Chroma, which was used to verify the connector. In order to fix notebook to be compatible with latest version, the notebook should be updated as soon as this PR is released. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> 1. Removed `ChromaBooleanConverter` to be compatible with Chroma 0.4.10. 2. Added note with latest tested version of Chroma in notebook and README file. 3. Updated unit tests. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Describe the bug
It looks like the problem is still there. I use the latest
Microsoft.SemanticKernel.Connectors.Memory.Chroma, 0.24.230911.2-preview
nuget package in the09-memory-with-chroma.ipynb
sample. I get the following error:The issue has been already reported several times: #2568, #2049 and a PR was created: #2072
To Reproduce
Steps to reproduce the behavior:
09-memory-with-chroma.ipynb
polygot notebookMicrosoft.SemanticKernel.Connectors.Memory.Chroma, 0.24.230911.2-preview
nuget packageThe text was updated successfully, but these errors were encountered: