Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: SKContextSequentialPlannerExtensions GetAvailableFunctionsAsync cleanup #2065

Closed
shawncal opened this issue Jul 19, 2023 · 0 comments · Fixed by #2107
Closed

.Net: SKContextSequentialPlannerExtensions GetAvailableFunctionsAsync cleanup #2065

shawncal opened this issue Jul 19, 2023 · 0 comments · Fixed by #2107
Assignees
@shawncal
Labels
triage

Comments

@shawncal
Copy link
Member

Remove the "?? new();"

    var excludedSkills = config.ExcludedSkills ?? new();
    var excludedFunctions = config.ExcludedFunctions ?? new();
    var includedFunctions = config.IncludedFunctions ?? new();
@shawncal shawncal self-assigned this Jul 19, 2023
shawncal added a commit that referenced this issue Jul 20, 2023
@shawncal
Minor cleanup of collection nullability.
199f055 
Fixes #2064
Fixes #2065
@shawncal shawncal mentioned this issue Jul 21, 2023
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Jul 21, 2023
@shawncal
.Net: Minor cleanup of collection nullability. (#2107)
798ebc5 
Collections are being checked for null, even when they cannot or should
not ever be null.

Fixes #2064
Fixes #2065

### Description
Removing nullable operators/checks from Skills collections

### Contribution Checklist
- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#dev-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawncal shawncal

Labels
triage
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.Net: Minor cleanup of collection nullability. microsoft/semantic-kernel
1 participant
@shawncal