Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tool-driven indents for *.props #750

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

DaveTryon
Copy link
Contributor

These changes are whitespace only

We've had a couple of recent changes where Visual Studio had to touch a .props file and the indents in the file were impacted. We've manually kept the tabs consistent with the previous versions, but it's never a great plan to try to fight your development tools.

Looking at https://github.com/microsoft/sbom-tool/blob/main/.editorconfig#L34-L36, .props files are supposed to use 2 spaces for tab indents:

# XML Configuration Files
[*.{xml,config,props,targets,nuspec,resx,ruleset,vsixmanifest,vsct}]
indent_size = 2

Based on this config, Visual Studio is doing exactly what it should; the previous indents didn't match the .editorconfig file, so the style was updated when the file was saved. These edits were created by opening the files in Visual Studio and using the Format Document option, which enforces the styles from .editorconfig.

I also checked all other files in the repo that match the aforementioned file filter and they already match the config--it's just these 3 files are are out of sync.

@DaveTryon DaveTryon requested a review from a team as a code owner October 12, 2024 00:14
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13%. Comparing base (e0df463) to head (5cc3416).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #750   +/-   ##
=======================================
  Coverage   70.13%   70.13%           
=======================================
  Files         277      277           
  Lines        8646     8646           
  Branches     1006     1006           
=======================================
  Hits         6064     6064           
  Misses       2063     2063           
  Partials      519      519           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaveTryon DaveTryon merged commit 2a6bf2d into main Oct 14, 2024
6 checks passed
@DaveTryon DaveTryon deleted the DaveTryon/use-tool-whitespaces branch October 14, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants