Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include dependency tree data about nuget and maven packages #746

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

jalkire
Copy link
Contributor

@jalkire jalkire commented Oct 9, 2024

This PR includes the changes from #457 with an updated pull from main--this PR is just to speed up the merge. Credit goes to @tarun06!

It includes hierarchical package data from CD for nuget and maven packages. It primarily impacts the relationships section of the SBOM.

A subsequent PR will add support for other package types.

@jalkire jalkire requested a review from a team as a code owner October 9, 2024 18:00
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.13%. Comparing base (2a6d71e) to head (dbca9ef).

Files with missing lines Patch % Lines
...rosoft.Sbom.Api/Executors/PackageInfoJsonWriter.cs 0.00% 0 Missing and 1 partial ⚠️
...i/Workflows/Helpers/RelationshipsArrayGenerator.cs 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #746      +/-   ##
==========================================
+ Coverage   70.06%   70.13%   +0.07%     
==========================================
  Files         277      277              
  Lines        8622     8646      +24     
  Branches     1002     1006       +4     
==========================================
+ Hits         6041     6064      +23     
  Misses       2063     2063              
- Partials      518      519       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jalkire jalkire merged commit e0df463 into main Oct 12, 2024
6 checks passed
@jalkire jalkire deleted the jalkire/nuget-maven-dependencytree branch October 12, 2024 00:05
jalkire added a commit that referenced this pull request Oct 15, 2024
This PR builds off of #746 to add support for ancestral dependencies of the remaining ecosystems supported by CD. The list of ecosystems supporting graph creation can be found here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants